From 5fafa7d09feb32485d82c4eddecd6785d3610d34 Mon Sep 17 00:00:00 2001 From: Ryan Nystrom Date: Sat, 28 Jul 2018 17:03:35 -0400 Subject: [PATCH] fix webview background color on iOS 12 --- Classes/Issues/Comments/Html/IssueCommentHtmlCell.swift | 3 ++- .../Assets.xcassets/splash_branches.imageset/Contents.json | 4 ++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/Classes/Issues/Comments/Html/IssueCommentHtmlCell.swift b/Classes/Issues/Comments/Html/IssueCommentHtmlCell.swift index 3d6726838..2c71d8d5f 100644 --- a/Classes/Issues/Comments/Html/IssueCommentHtmlCell.swift +++ b/Classes/Issues/Comments/Html/IssueCommentHtmlCell.swift @@ -45,6 +45,7 @@ final class IssueCommentHtmlCell: IssueCommentBaseCell, ListBindable, UIWebViewD color: #\(Styles.Colors.Gray.dark); padding: \(Styles.Sizes.columnSpacing)px 0 0; margin: 0; + background-color: #ffffff; } * { font-family: -apple-system; font-size: \(Styles.Text.body.preferredFont.pointSize)px; } b, strong{font-weight: \(Styles.Sizes.HTML.boldWeight);} @@ -121,7 +122,7 @@ final class IssueCommentHtmlCell: IssueCommentBaseCell, ListBindable, UIWebViewD override init(frame: CGRect) { super.init(frame: frame) - webView.backgroundColor = .clear + webView.backgroundColor = .white webView.delegate = self webView.scrollView.bounces = false diff --git a/Resources/Assets.xcassets/splash_branches.imageset/Contents.json b/Resources/Assets.xcassets/splash_branches.imageset/Contents.json index 6eee64548..7a89710ec 100644 --- a/Resources/Assets.xcassets/splash_branches.imageset/Contents.json +++ b/Resources/Assets.xcassets/splash_branches.imageset/Contents.json @@ -1,5 +1,9 @@ { "images" : [ + { + "idiom" : "universal", + "scale" : "1x" + }, { "idiom" : "universal", "filename" : "splash_branches@2x.png",