From 502347d5e4b066eef24fe304e6e150b2aa5c1bfd Mon Sep 17 00:00:00 2001 From: Tim Johnsen Date: Sun, 18 Nov 2018 15:33:48 -0800 Subject: [PATCH] Fix deep links now working as expected on cold start of the app. --- Classes/View Controllers/SplitViewControllerDelegate.swift | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Classes/View Controllers/SplitViewControllerDelegate.swift b/Classes/View Controllers/SplitViewControllerDelegate.swift index d60e704de..208535732 100644 --- a/Classes/View Controllers/SplitViewControllerDelegate.swift +++ b/Classes/View Controllers/SplitViewControllerDelegate.swift @@ -94,7 +94,10 @@ final class SplitViewControllerDelegate: UISplitViewControllerDelegate { guard let tab = splitViewController.viewControllers.first as? UITabBarController else { return false } - if splitViewController.isCollapsed { + // isCollapsed can be false even when showing a single view controller on iPhone. + // We check viewControllers.count as well to ensure we don't skip showing view controllers on the nav stack that we'd like to. + // https://github.com/GitHawkApp/GitHawk/issues/2450 + if splitViewController.isCollapsed || splitViewController.viewControllers.count == 1 { if let nav = vc as? UINavigationController, let first = nav.viewControllers.first { tab.selectedViewController?.show(first, sender: sender) } else {