-
Notifications
You must be signed in to change notification settings - Fork 7
Combine "create" and "upload" steps #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combine "create" and "upload" steps #60
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR consolidates the GitHub release creation and artifact upload process from two separate steps into a single command. The workflow now creates the release and uploads distribution files in one operation instead of two sequential steps.
Key Changes:
- Merged "Create GitHub Release" and "Upload GitHub Release" steps into a single step
- Combined
gh release createand file upload into one command using thedist/**glob pattern
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ffc3c94 to
c5b02d1
Compare
c5b02d1 to
ca0f0d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
smoke test |
Deployment Triggered 🚀kevinbackhouse, started a branch deployment to production (branch: You can watch the progress here 🔗 Details{
"type": "branch",
"environment": {
"name": "production",
"url": null
},
"deployment": {
"timestamp": "2025-11-07T18:00:04.085Z",
"logs": "https://github.com/GitHubSecurityLab/seclab-taskflow-agent/actions/runs/19176866491"
},
"git": {
"branch": "ca0f0d637aabb46e9d86bc6cde2b15e10cdae2d0",
"commit": "ca0f0d637aabb46e9d86bc6cde2b15e10cdae2d0",
"verified": true,
"committer": "kevinbackhouse",
"html_url": "https://github.com/GitHubSecurityLab/seclab-taskflow-agent/commit/ca0f0d637aabb46e9d86bc6cde2b15e10cdae2d0"
},
"context": {
"actor": "kevinbackhouse",
"noop": false,
"fork": true,
"comment": {
"created_at": "2025-11-07T17:59:48Z",
"updated_at": "2025-11-07T17:59:48Z",
"body": "smoke test",
"html_url": "https://github.com/GitHubSecurityLab/seclab-taskflow-agent/pull/60#issuecomment-3503985626"
}
},
"parameters": {
"raw": null,
"parsed": null
}
} |
Deployment Results ❌kevinbackhouse had a failure when deploying branch Details{
"status": "failure",
"environment": {
"name": "production",
"url": null
},
"deployment": {
"id": 3274607266,
"timestamp": "2025-11-07T18:00:07.059Z",
"logs": "https://github.com/GitHubSecurityLab/seclab-taskflow-agent/actions/runs/19176866491",
"duration": 3
},
"git": {
"branch": "ca0f0d637aabb46e9d86bc6cde2b15e10cdae2d0",
"commit": "ca0f0d637aabb46e9d86bc6cde2b15e10cdae2d0",
"verified": true
},
"context": {
"actor": "kevinbackhouse",
"noop": false,
"fork": true
},
"reviews": {
"count": 1,
"decision": "APPROVED"
},
"parameters": {
"raw": null,
"parsed": null
}
} |
|
smoke test |
Deployment Triggered 🚀kevinbackhouse, started a branch deployment to production (branch: You can watch the progress here 🔗 Details{
"type": "branch",
"environment": {
"name": "production",
"url": null
},
"deployment": {
"timestamp": "2025-11-07T18:11:27.548Z",
"logs": "https://github.com/GitHubSecurityLab/seclab-taskflow-agent/actions/runs/19177162089"
},
"git": {
"branch": "ca0f0d637aabb46e9d86bc6cde2b15e10cdae2d0",
"commit": "ca0f0d637aabb46e9d86bc6cde2b15e10cdae2d0",
"verified": true,
"committer": "kevinbackhouse",
"html_url": "https://github.com/GitHubSecurityLab/seclab-taskflow-agent/commit/ca0f0d637aabb46e9d86bc6cde2b15e10cdae2d0"
},
"context": {
"actor": "kevinbackhouse",
"noop": false,
"fork": true,
"comment": {
"created_at": "2025-11-07T18:11:14Z",
"updated_at": "2025-11-07T18:11:14Z",
"body": "smoke test",
"html_url": "https://github.com/GitHubSecurityLab/seclab-taskflow-agent/pull/60#issuecomment-3504053790"
}
},
"parameters": {
"raw": null,
"parsed": null
}
} |
Deployment Results ✅kevinbackhouse successfully deployed branch Details{
"status": "success",
"environment": {
"name": "production",
"url": null
},
"deployment": {
"id": 3274668136,
"timestamp": "2025-11-07T18:16:05.296Z",
"logs": "https://github.com/GitHubSecurityLab/seclab-taskflow-agent/actions/runs/19177162089",
"duration": 278
},
"git": {
"branch": "ca0f0d637aabb46e9d86bc6cde2b15e10cdae2d0",
"commit": "ca0f0d637aabb46e9d86bc6cde2b15e10cdae2d0",
"verified": true
},
"context": {
"actor": "kevinbackhouse",
"noop": false,
"fork": true
},
"reviews": {
"count": 1,
"decision": "APPROVED"
},
"parameters": {
"raw": null,
"parsed": null
}
} |
I've enabled immutable releases, so the release get locked immediately after the "create" step, causing the "upload" step to fail. But it turns out that the upload can be combined into the create step, so there's no need for two steps.