Skip to content

Conversation

@kevinbackhouse
Copy link
Collaborator

I think the ABOUT file in the logs directory was a hack to make sure that the directory exists. It's better to use mkdir so that it also works if the tool is run from a different directory.

Copilot AI review requested due to automatic review settings November 7, 2025 16:33
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates log directory handling to dynamically create the logs/ directory at runtime instead of requiring it to exist in the repository. The code now uses pathlib.Path to programmatically create the directory before attempting to write log files.

  • Replaced hardcoded string path with pathlib.Path object for log directory creation
  • Added automatic directory creation with mkdir(parents=True, exist_ok=True)
  • Updated .gitignore to exclude the entire logs/ directory instead of just *.log files
  • Removed the placeholder logs/ABOUT file since the directory is now created programmatically

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
src/seclab_taskflow_agent/__main__.py Added dynamic log directory creation using pathlib and updated log file path construction
logs/ABOUT Removed placeholder file as logs directory is now created programmatically
.gitignore Updated to ignore entire logs directory instead of just *.log files

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@kevinbackhouse kevinbackhouse merged commit bc3bc3f into GitHubSecurityLab:main Nov 7, 2025
9 checks passed
@kevinbackhouse kevinbackhouse deleted the log_dir branch November 7, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants