diff --git a/src/GitVersionCore.Tests/VersionConverters/ProjectFileUpdaterTests.cs b/src/GitVersionCore.Tests/VersionConverters/ProjectFileUpdaterTests.cs index 1be9f3f599..d6b1e57e4d 100644 --- a/src/GitVersionCore.Tests/VersionConverters/ProjectFileUpdaterTests.cs +++ b/src/GitVersionCore.Tests/VersionConverters/ProjectFileUpdaterTests.cs @@ -52,6 +52,25 @@ public void CanUpdateProjectFileWithStandardProjectFileXml(string xml) canUpdate.ShouldBe(true); } + [TestCase(@" + + + Exe + netcoreapp3.1 + + +")] + [Category(NoMono)] + [Description(NoMonoDescription)] + public void CanUpdateProjectFileWithStandardWebProjectFileXml(string xml) + { + using var projectFileUpdater = new ProjectFileUpdater(log, fileSystem); + + var canUpdate = projectFileUpdater.CanUpdateProjectFile(XElement.Parse(xml)); + + canUpdate.ShouldBe(true); + } + [TestCase(@" diff --git a/src/GitVersionCore/VersionConverters/AssemblyInfo/ProjectFileUpdater.cs b/src/GitVersionCore/VersionConverters/AssemblyInfo/ProjectFileUpdater.cs index 84a9224ff7..6deb5281f8 100644 --- a/src/GitVersionCore/VersionConverters/AssemblyInfo/ProjectFileUpdater.cs +++ b/src/GitVersionCore/VersionConverters/AssemblyInfo/ProjectFileUpdater.cs @@ -102,11 +102,12 @@ internal bool CanUpdateProjectFile(XElement xmlRoot) return false; } - var supportedSdk = "Microsoft.NET.Sdk"; + var supportedSdks = new[] { "Microsoft.NET.Sdk", "Microsoft.NET.Sdk.Web" }; var sdkAttribute = xmlRoot.Attribute("Sdk"); - if (sdkAttribute == null || sdkAttribute.Value != supportedSdk) + if (sdkAttribute == null || !supportedSdks.Contains(sdkAttribute.Value)) { - log.Warning($"Specified project file Sdk ({sdkAttribute?.Value}) is not supported, please ensure the project sdk is {supportedSdk}."); + var supportedSdkString = string.Join("|", supportedSdks); + log.Warning($"Specified project file Sdk ({sdkAttribute?.Value}) is not supported, please ensure the project sdk is of the following: {supportedSdkString}."); return false; }