From e97c4f1f83fc0fe3d9b02f204b0c7527550ddeb1 Mon Sep 17 00:00:00 2001 From: Eliah Kagan Date: Wed, 22 Jan 2025 05:37:11 -0500 Subject: [PATCH] Make `test-fixtures-windows` required for PR auto-merge Since #1663, the `test-fixtures-windows` CI job checks actual failures against a list of specific tests that are known to fail on Windows when `GIX_TEST_IGNORE_ARCHIVES=1`. It is therefore capable of providing useful information about new failures, or newly passing tests that should be removed from the list, if the job ever does fail. The job also seems not to fail. This is to say that while #1358 is not fixed, the `test-fixtures-windows` job has a very low rate of failure and, if it does fail, something new and interesting would be happening such that we would want to know about it and probably not immediately merge a PR that caused it without checking how and why that happened. This adds `test-fixtures-windows` to the list of jobs that are dependencies of a required check for branch protection based PR auto-merge. --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 76b1b5f100e..06d9491298d 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -406,7 +406,6 @@ jobs: # List all jobs that are intended NOT to block PR auto-merge here. EXPECTED_NONBLOCKING_JOBS: |- test-fast-arm - test-fixtures-windows cargo-deny-advisories wasm tests-pass @@ -443,6 +442,7 @@ jobs: - test - test-journey - test-fast + - test-fixtures-windows - test-32bit - lint - cargo-deny