Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX #740, Disable 'Autoplay' on videos recorded into Milestones #757

Closed
wants to merge 21 commits into from
Closed

FIX #740, Disable 'Autoplay' on videos recorded into Milestones #757

wants to merge 21 commits into from

Commits on May 6, 2019

  1. Transform description from iframe to video element 

    As server is sending video source of milestone video as description inside iframe tag. 
Which generates a video element by browser inside iframe having auto-play and other controls enabled by default leading to the auto-play issue.
As part of the front-end only fix, here i am converting the iframe to a video tag by reading
the iframe source and applying it to the video element.
    @nadirlaskar
    nadirlaskar committed May 6, 2019
    Configuration menu
    Copy the full SHA
    765cec3 View commit details
    Browse the repository at this point in the history

  2. Repalced use of jquery with regex to extract url 

    Instead of using jquery to read iframe src  attribute, modified  to using regex to extract the attribute.
    @nadirlaskar
    nadirlaskar committed May 6, 2019
    Configuration menu
    Copy the full SHA
    063cec9 View commit details
    Browse the repository at this point in the history

  3. Transform a copy of description to video tag 

    In order to not mutate the state of the component, making a copy of description for transforming
and passing it to create react node.
    @nadirlaskar
    nadirlaskar committed May 6, 2019
    Configuration menu
    Copy the full SHA
    dea7101 View commit details
    Browse the repository at this point in the history

  4. Add check for undefined description value 

    Some cases the description value of the milestone is set to undefined,
added a if condition to check for that case.
    @nadirlaskar
    nadirlaskar committed May 6, 2019
    Configuration menu
    Copy the full SHA
    7e0d2a5 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2019

  1. Merge branch 'develop' into patch-1

    @nadirlaskar
    nadirlaskar committed May 17, 2019
    Configuration menu
    Copy the full SHA
    94153d3 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2019

  1. eslint-fix

    @nadirlaskar
    nadirlaskar committed May 18, 2019
    Configuration menu
    Copy the full SHA
    6e5b16a View commit details
    Browse the repository at this point in the history

Commits on May 19, 2019

  1. fixed incorrect import

    @nadirlaskar
    nadirlaskar committed May 19, 2019
    Configuration menu
    Copy the full SHA
    7bc885d View commit details
    Browse the repository at this point in the history

  2. eslint use of label without htmlFor, replaced with span

    @nadirlaskar
    nadirlaskar committed May 19, 2019
    Configuration menu
    Copy the full SHA
    a148647 View commit details
    Browse the repository at this point in the history

  3. eslint space and tab fixes

    @nadirlaskar
    nadirlaskar committed May 19, 2019
    Configuration menu
    Copy the full SHA
    7b42e24 View commit details
    Browse the repository at this point in the history

  4. removed quotes from eslint npm script

    @nadirlaskar
    nadirlaskar committed May 19, 2019
    Configuration menu
    Copy the full SHA
    19d1de2 View commit details
    Browse the repository at this point in the history

  5. updated import to css from scss

    @nadirlaskar
    nadirlaskar committed May 19, 2019
    Configuration menu
    Copy the full SHA
    224d534 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'develop' into eslint-fix

    @nadirlaskar
    nadirlaskar committed May 19, 2019
    Configuration menu
    Copy the full SHA
    707b272 View commit details
    Browse the repository at this point in the history

  7. use destructor instead, eslint-fix

    @nadirlaskar
    nadirlaskar committed May 19, 2019
    Configuration menu
    Copy the full SHA
    b7f00be View commit details
    Browse the repository at this point in the history

  8. added mock localstorage to setupTests required by localforage

    @nadirlaskar
    nadirlaskar committed May 19, 2019
    Configuration menu
    Copy the full SHA
    8cf1480 View commit details
    Browse the repository at this point in the history

  9. updated commitTime test data to be timestamp from date string

    @nadirlaskar
    nadirlaskar committed May 19, 2019
    Configuration menu
    Copy the full SHA
    1bc8b9a View commit details
    Browse the repository at this point in the history

  10. added relative path to imports

    @nadirlaskar
    nadirlaskar committed May 19, 2019
    Configuration menu
    Copy the full SHA
    05d82e2 View commit details
    Browse the repository at this point in the history

  11. use amount as amountRemaining in donation model when absent

    @nadirlaskar
    nadirlaskar committed May 19, 2019
    Configuration menu
    Copy the full SHA
    4f08c8f View commit details
    Browse the repository at this point in the history

  12. added check for amount attribute to convert to wei from bigNumber eth

    @nadirlaskar
    nadirlaskar committed May 19, 2019
    Configuration menu
    Copy the full SHA
    a137a0b View commit details
    Browse the repository at this point in the history

  13. Merge branch 'eslint-fix' into patch-1

    @nadirlaskar
    nadirlaskar committed May 19, 2019
    Configuration menu
    Copy the full SHA
    5349f00 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2019

  1. use destructor and added spaces for lint issue fixes

    @nadirlaskar
    nadirlaskar committed May 23, 2019
    Configuration menu
    Copy the full SHA
    6fa2d8b View commit details
    Browse the repository at this point in the history

Commits on May 29, 2019

  1. Merge branch 'patch-1' of https://github.com/nadirlaskar/giveth-dapp … 

    …into patch-1
    @nadirlaskar
    nadirlaskar committed May 29, 2019
    Configuration menu
    Copy the full SHA
    a697336 View commit details
    Browse the repository at this point in the history