From 8ec0ce28d1f47ca1bd5b2b0bb494fee39c3f6f79 Mon Sep 17 00:00:00 2001 From: Maarten Segers Date: Mon, 13 May 2019 16:03:28 +0200 Subject: [PATCH 01/22] Test codeclimate --- src/GroupTypeManager.php | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/GroupTypeManager.php b/src/GroupTypeManager.php index 7ed4554ae..e68e45994 100644 --- a/src/GroupTypeManager.php +++ b/src/GroupTypeManager.php @@ -8,8 +8,7 @@ use Drupal\Core\Routing\RouteBuilderInterface; use Drupal\Core\Cache\CacheBackendInterface; use Drupal\og\Event\GroupCreationEvent; -use Drupal\og\Event\GroupCreationEventInterface; -use Symfony\Component\EventDispatcher\EventDispatcherInterface; +use Drupal\node\Entity\Node; /** * A manager to keep track of which entity type/bundles are OG group enabled. From e28805328d1d87f72859f6509d0b02b2f7435bf5 Mon Sep 17 00:00:00 2001 From: Maarten Segers Date: Mon, 13 May 2019 16:10:19 +0200 Subject: [PATCH 02/22] Create .codeclimate.yml --- .codeclimate.yml | 84 ++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 84 insertions(+) create mode 100644 .codeclimate.yml diff --git a/.codeclimate.yml b/.codeclimate.yml new file mode 100644 index 000000000..356802eb9 --- /dev/null +++ b/.codeclimate.yml @@ -0,0 +1,84 @@ +version: "2" + +prepare: + fetch: + - url: "https://raw.githubusercontent.com/digipolisgent/ci_config-files-and-scripts/master/php/drupal8/.phpmd.xml" + path: ".phpmd.xml" + - url: "https://raw.githubusercontent.com/digipolisgent/ci_config-files-and-scripts/master/php/drupal8/.csslintrc" + path: ".csslintrc" + - url: "https://raw.githubusercontent.com/digipolisgent/ci_config-files-and-scripts/master/php/drupal8/.eslintrc.json" + path: ".eslintrc.json" + - url: "https://raw.githubusercontent.com/digipolisgent/ci_config-files-and-scripts/master/php/drupal8/.eslintignore" + path: ".eslintignore" + +checks: + argument-count: + enabled: false + complex-logic: + config: + threshold: 4 + file-lines: + config: + threshold: 250 + method-complexity: + config: + threshold: 5 + method-count: + config: + threshold: 20 + method-lines: + config: + threshold: 50 + nested-control-flow: + config: + threshold: 4 + return-statements: + config: + threshold: 4 + similar-code: + config: + threshold: # language-specific defaults. an override will affect all languages. + identical-code: + config: + threshold: # language-specific defaults. an override will affect all languages. + +plugins: + phpcodesniffer: + enabled: true + config: + standard: "Drupal" + file_extensions: "php,inc,module,install" + phpmd: + enabled: true + config: + file_extensions: + - php + - inc + - module + - install + rulesets: ".phpmd.xml" + csslint: + enabled: true + eslint: + enabled: true + duplication: + enabled: true + config: + languages: + php: + javascript: + fixme: + enabled: true + markdownlint: + enabled: true + issue_override: + severity: minor + +exclude_patterns: +- "config/" +- "translations/" +- "**/vendor/**/*" +- "**/.idea/**/*" +- "**/tests/**/*" +- "**/*.settings.php" +- "RoboFile.php" From 30d678ecc32acdd78831ee9889d8f1c416d443f6 Mon Sep 17 00:00:00 2001 From: Maarten Segers Date: Mon, 13 May 2019 18:47:13 +0200 Subject: [PATCH 03/22] Alleviate thresholds x4 --- .codeclimate.yml | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/.codeclimate.yml b/.codeclimate.yml index 356802eb9..d3ab4957f 100644 --- a/.codeclimate.yml +++ b/.codeclimate.yml @@ -16,25 +16,25 @@ checks: enabled: false complex-logic: config: - threshold: 4 + threshold: 16 file-lines: config: - threshold: 250 + threshold: 1000 method-complexity: config: - threshold: 5 + threshold: 20 method-count: config: - threshold: 20 + threshold: 80 method-lines: config: - threshold: 50 + threshold: 200 nested-control-flow: config: - threshold: 4 + threshold: 16 return-statements: config: - threshold: 4 + threshold: 16 similar-code: config: threshold: # language-specific defaults. an override will affect all languages. From ae08b3396e91e5e07c7a31dff224d31e1aaffbae Mon Sep 17 00:00:00 2001 From: Maarten Segers Date: Mon, 13 May 2019 19:03:10 +0200 Subject: [PATCH 04/22] Use .csslintrc from Drupal core --- .codeclimate.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.codeclimate.yml b/.codeclimate.yml index d3ab4957f..977a6fae2 100644 --- a/.codeclimate.yml +++ b/.codeclimate.yml @@ -4,7 +4,7 @@ prepare: fetch: - url: "https://raw.githubusercontent.com/digipolisgent/ci_config-files-and-scripts/master/php/drupal8/.phpmd.xml" path: ".phpmd.xml" - - url: "https://raw.githubusercontent.com/digipolisgent/ci_config-files-and-scripts/master/php/drupal8/.csslintrc" + - url: "https://git.drupalcode.org/project/drupal/raw/8.7.x/.csslintrc" path: ".csslintrc" - url: "https://raw.githubusercontent.com/digipolisgent/ci_config-files-and-scripts/master/php/drupal8/.eslintrc.json" path: ".eslintrc.json" From 26e273ba9534d524c11df371ed261e17ae60f265 Mon Sep 17 00:00:00 2001 From: Maarten Segers Date: Mon, 13 May 2019 19:07:10 +0200 Subject: [PATCH 05/22] Use .eslintrc.json from Drupal core --- .codeclimate.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.codeclimate.yml b/.codeclimate.yml index 977a6fae2..d37ea7ad8 100644 --- a/.codeclimate.yml +++ b/.codeclimate.yml @@ -6,7 +6,7 @@ prepare: path: ".phpmd.xml" - url: "https://git.drupalcode.org/project/drupal/raw/8.7.x/.csslintrc" path: ".csslintrc" - - url: "https://raw.githubusercontent.com/digipolisgent/ci_config-files-and-scripts/master/php/drupal8/.eslintrc.json" + - url: "https://git.drupalcode.org/project/drupal/raw/8.7.x/core/.eslintrc.json" path: ".eslintrc.json" - url: "https://raw.githubusercontent.com/digipolisgent/ci_config-files-and-scripts/master/php/drupal8/.eslintignore" path: ".eslintignore" From d7a4661c1090abf4f4354d401dccd79740f9caeb Mon Sep 17 00:00:00 2001 From: Maarten Segers Date: Mon, 13 May 2019 19:08:45 +0200 Subject: [PATCH 06/22] Use .eslintignore from Drupal core --- .codeclimate.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.codeclimate.yml b/.codeclimate.yml index d37ea7ad8..dd2de5597 100644 --- a/.codeclimate.yml +++ b/.codeclimate.yml @@ -8,7 +8,7 @@ prepare: path: ".csslintrc" - url: "https://git.drupalcode.org/project/drupal/raw/8.7.x/core/.eslintrc.json" path: ".eslintrc.json" - - url: "https://raw.githubusercontent.com/digipolisgent/ci_config-files-and-scripts/master/php/drupal8/.eslintignore" + - url: "https://git.drupalcode.org/project/drupal/raw/8.7.x/core/.eslintignore" path: ".eslintignore" checks: From 90a4d72d99ea5e1128b96eb6343898bbed908753 Mon Sep 17 00:00:00 2001 From: Maarten Segers Date: Mon, 13 May 2019 19:13:26 +0200 Subject: [PATCH 07/22] Add codeclimate to travis --- .travis.yml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/.travis.yml b/.travis.yml index c9a113c28..2c6c8c230 100644 --- a/.travis.yml +++ b/.travis.yml @@ -76,4 +76,12 @@ before_script: # Export database variable for kernel tests. - export SIMPLETEST_DB=mysql://root:@127.0.0.1/og + # Get the CodeClimate test reporter. + - curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./cc-test-reporter + - chmod +x ./cc-test-reporter + - ./cc-test-reporter before-build + script: DRUPAL_DIR=$DRUPAL_DIR MODULE_DIR=$MODULE_DIR $MODULE_DIR/scripts/travis-ci/run-test.sh $TEST_SUITE + +after_script: + - if [ "$TRAVIS_PULL_REQUEST" == "false" ] && [ "${TEST_SUITE}" != "PHP_CodeSniffer" ]; then ./cc-test-reporter after-build --coverage-input-type clover --exit-code $TRAVIS_TEST_RESULT; fi From d640963f9feb74fefc70afaa564e38f9fd329d3f Mon Sep 17 00:00:00 2001 From: Maarten Segers Date: Mon, 13 May 2019 19:17:04 +0200 Subject: [PATCH 08/22] Revert test --- src/GroupTypeManager.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/GroupTypeManager.php b/src/GroupTypeManager.php index e68e45994..50d0c6926 100644 --- a/src/GroupTypeManager.php +++ b/src/GroupTypeManager.php @@ -8,6 +8,8 @@ use Drupal\Core\Routing\RouteBuilderInterface; use Drupal\Core\Cache\CacheBackendInterface; use Drupal\og\Event\GroupCreationEvent; +use Drupal\og\Event\GroupCreationEventInterface; +use Symfony\Component\EventDispatcher\EventDispatcherInterface; use Drupal\node\Entity\Node; /** From 3b3334371ce5335e290f07da39667de11be463ae Mon Sep 17 00:00:00 2001 From: Maarten Segers Date: Mon, 13 May 2019 20:13:12 +0200 Subject: [PATCH 09/22] Cleanup test --- src/GroupTypeManager.php | 1 - 1 file changed, 1 deletion(-) diff --git a/src/GroupTypeManager.php b/src/GroupTypeManager.php index 50d0c6926..7ed4554ae 100644 --- a/src/GroupTypeManager.php +++ b/src/GroupTypeManager.php @@ -10,7 +10,6 @@ use Drupal\og\Event\GroupCreationEvent; use Drupal\og\Event\GroupCreationEventInterface; use Symfony\Component\EventDispatcher\EventDispatcherInterface; -use Drupal\node\Entity\Node; /** * A manager to keep track of which entity type/bundles are OG group enabled. From acd774403dea5de65d3701952a9088cfc46195a1 Mon Sep 17 00:00:00 2001 From: Maarten Segers Date: Mon, 13 May 2019 20:13:54 +0200 Subject: [PATCH 10/22] Disable some plugins --- .codeclimate.yml | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/.codeclimate.yml b/.codeclimate.yml index dd2de5597..448143e61 100644 --- a/.codeclimate.yml +++ b/.codeclimate.yml @@ -15,20 +15,15 @@ checks: argument-count: enabled: false complex-logic: - config: - threshold: 16 + enabled: false file-lines: - config: - threshold: 1000 + enabled: false method-complexity: - config: - threshold: 20 + enabled: false method-count: - config: - threshold: 80 + enabled: false method-lines: - config: - threshold: 200 + enabled: false nested-control-flow: config: threshold: 16 @@ -81,4 +76,3 @@ exclude_patterns: - "**/.idea/**/*" - "**/tests/**/*" - "**/*.settings.php" -- "RoboFile.php" From 467b39f2183b33baf3697998e4eee253bc94e902 Mon Sep 17 00:00:00 2001 From: Maarten Segers Date: Mon, 13 May 2019 20:59:23 +0200 Subject: [PATCH 11/22] Add DrupalPractice phpcs standard --- .codeclimate.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.codeclimate.yml b/.codeclimate.yml index 448143e61..be4d90906 100644 --- a/.codeclimate.yml +++ b/.codeclimate.yml @@ -41,7 +41,7 @@ plugins: phpcodesniffer: enabled: true config: - standard: "Drupal" + standard: "Drupal,DrupalPractice" file_extensions: "php,inc,module,install" phpmd: enabled: true From c8f478ac6a310b67180113db4eb00b49bcccbc69 Mon Sep 17 00:00:00 2001 From: Maarten Segers Date: Tue, 14 May 2019 08:00:58 +0200 Subject: [PATCH 12/22] Added coverage to phpunit --- scripts/travis-ci/run-test.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/travis-ci/run-test.sh b/scripts/travis-ci/run-test.sh index 07797a6a9..104dcc66e 100755 --- a/scripts/travis-ci/run-test.sh +++ b/scripts/travis-ci/run-test.sh @@ -27,7 +27,7 @@ case "$1" in EXIT=0 for i in ${TEST_DIRS[@]}; do echo " > Executing tests from $i" - ./vendor/bin/phpunit -c ./core/phpunit.xml.dist $i || EXIT=1 + ./vendor/bin/phpunit -c ./core/phpunit.xml.dist $i --coverage-clover "$TRAVIS_BUILD_DIR/build/logs/clover.xml" || EXIT=1 done exit $EXIT esac From 6a0585933d6437712b074c3034147a88a2cfc98c Mon Sep 17 00:00:00 2001 From: Maarten Segers Date: Tue, 14 May 2019 08:24:17 +0200 Subject: [PATCH 13/22] Keep a copy of xdebug --- .travis.yml | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/.travis.yml b/.travis.yml index 2c6c8c230..fc7168e4f 100644 --- a/.travis.yml +++ b/.travis.yml @@ -33,6 +33,7 @@ before_script: # Remove Xdebug as we don't need it and it causes "PHP Fatal error: Maximum # function nesting level of '256' reached." # We also don't care if that file exists or not on PHP 7. + - cp $HOME/.phpenv/versions/$(phpenv global)/etc/conf.d/xdebug.ini /tmp - phpenv config-rm xdebug.ini || true # Make sure Composer is up to date. @@ -76,12 +77,4 @@ before_script: # Export database variable for kernel tests. - export SIMPLETEST_DB=mysql://root:@127.0.0.1/og - # Get the CodeClimate test reporter. - - curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./cc-test-reporter - - chmod +x ./cc-test-reporter - - ./cc-test-reporter before-build - script: DRUPAL_DIR=$DRUPAL_DIR MODULE_DIR=$MODULE_DIR $MODULE_DIR/scripts/travis-ci/run-test.sh $TEST_SUITE - -after_script: - - if [ "$TRAVIS_PULL_REQUEST" == "false" ] && [ "${TEST_SUITE}" != "PHP_CodeSniffer" ]; then ./cc-test-reporter after-build --coverage-input-type clover --exit-code $TRAVIS_TEST_RESULT; fi From adcc2f66f27817c8db2bcc41b4e0fa2b74675caa Mon Sep 17 00:00:00 2001 From: Maarten Segers Date: Tue, 14 May 2019 08:30:01 +0200 Subject: [PATCH 14/22] Re-enable xdebug to support PHPUnit code coverage. --- .travis.yml | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index fc7168e4f..a95ffab25 100644 --- a/.travis.yml +++ b/.travis.yml @@ -77,4 +77,15 @@ before_script: # Export database variable for kernel tests. - export SIMPLETEST_DB=mysql://root:@127.0.0.1/og -script: DRUPAL_DIR=$DRUPAL_DIR MODULE_DIR=$MODULE_DIR $MODULE_DIR/scripts/travis-ci/run-test.sh $TEST_SUITE + # Get the CodeClimate test reporter. + - curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./cc-test-reporter + - chmod +x ./cc-test-reporter + - ./cc-test-reporter before-build + +script: + // Re-enable xdebug to support PHPUnit code coverage. + - if [ "$TRAVIS_PULL_REQUEST" == "false" ] && [ "${TEST_SUITE}" != "PHP_CodeSniffer" ]; then phpenv config-add /tmp/xdebug.ini; fi + - DRUPAL_DIR=$DRUPAL_DIR MODULE_DIR=$MODULE_DIR $MODULE_DIR/scripts/travis-ci/run-test.sh $TEST_SUITE + +after_script: + - if [ "$TRAVIS_PULL_REQUEST" == "false" ] && [ "${TEST_SUITE}" != "PHP_CodeSniffer" ]; then ./cc-test-reporter after-build --coverage-input-type clover --exit-code $TRAVIS_TEST_RESULT; fi From abfac022e5cbf1505e05ba322c8fcd4db8228af7 Mon Sep 17 00:00:00 2001 From: Maarten Segers Date: Tue, 14 May 2019 09:03:22 +0200 Subject: [PATCH 15/22] Re-enable xdebug to support PHPUnit code coverage. --- .travis.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index a95ffab25..0c2004e4a 100644 --- a/.travis.yml +++ b/.travis.yml @@ -82,9 +82,10 @@ before_script: - chmod +x ./cc-test-reporter - ./cc-test-reporter before-build -script: - // Re-enable xdebug to support PHPUnit code coverage. + # Re-enable xdebug to support PHPUnit code coverage. - if [ "$TRAVIS_PULL_REQUEST" == "false" ] && [ "${TEST_SUITE}" != "PHP_CodeSniffer" ]; then phpenv config-add /tmp/xdebug.ini; fi + +script: - DRUPAL_DIR=$DRUPAL_DIR MODULE_DIR=$MODULE_DIR $MODULE_DIR/scripts/travis-ci/run-test.sh $TEST_SUITE after_script: From 5cac01e4e1eba18ec139f508f04ad476216bcc77 Mon Sep 17 00:00:00 2001 From: Maarten Segers Date: Tue, 14 May 2019 09:03:43 +0200 Subject: [PATCH 16/22] Update .travis.yml --- .travis.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index 0c2004e4a..dc91a4ce8 100644 --- a/.travis.yml +++ b/.travis.yml @@ -85,8 +85,7 @@ before_script: # Re-enable xdebug to support PHPUnit code coverage. - if [ "$TRAVIS_PULL_REQUEST" == "false" ] && [ "${TEST_SUITE}" != "PHP_CodeSniffer" ]; then phpenv config-add /tmp/xdebug.ini; fi -script: - - DRUPAL_DIR=$DRUPAL_DIR MODULE_DIR=$MODULE_DIR $MODULE_DIR/scripts/travis-ci/run-test.sh $TEST_SUITE +script: DRUPAL_DIR=$DRUPAL_DIR MODULE_DIR=$MODULE_DIR $MODULE_DIR/scripts/travis-ci/run-test.sh $TEST_SUITE after_script: - if [ "$TRAVIS_PULL_REQUEST" == "false" ] && [ "${TEST_SUITE}" != "PHP_CodeSniffer" ]; then ./cc-test-reporter after-build --coverage-input-type clover --exit-code $TRAVIS_TEST_RESULT; fi From 65e409567813d1f077d8be7994d4b2f8aac9c744 Mon Sep 17 00:00:00 2001 From: Maarten Segers Date: Tue, 14 May 2019 09:08:00 +0200 Subject: [PATCH 17/22] Added documentation for Xdebug - Xdebug is needed for code coverage - Removed deprecated comment (in the past Xdebug wasn't supported for PHP 7) --- .travis.yml | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/.travis.yml b/.travis.yml index dc91a4ce8..691e9b89a 100644 --- a/.travis.yml +++ b/.travis.yml @@ -30,11 +30,9 @@ mysql: encoding: utf8 before_script: - # Remove Xdebug as we don't need it and it causes "PHP Fatal error: Maximum - # function nesting level of '256' reached." - # We also don't care if that file exists or not on PHP 7. + # Disable Xdebug to speed up Travis. - cp $HOME/.phpenv/versions/$(phpenv global)/etc/conf.d/xdebug.ini /tmp - - phpenv config-rm xdebug.ini || true + - phpenv config-rm xdebug.ini # Make sure Composer is up to date. - composer self-update From 9eb65fdb9e0a7e63a295c8bbeb49cb739d9867f6 Mon Sep 17 00:00:00 2001 From: Maarten Segers Date: Tue, 14 May 2019 15:08:23 +0200 Subject: [PATCH 18/22] Disable xdebug --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 691e9b89a..dfc86df89 100644 --- a/.travis.yml +++ b/.travis.yml @@ -81,7 +81,7 @@ before_script: - ./cc-test-reporter before-build # Re-enable xdebug to support PHPUnit code coverage. - - if [ "$TRAVIS_PULL_REQUEST" == "false" ] && [ "${TEST_SUITE}" != "PHP_CodeSniffer" ]; then phpenv config-add /tmp/xdebug.ini; fi + # - if [ "$TRAVIS_PULL_REQUEST" == "false" ] && [ "${TEST_SUITE}" != "PHP_CodeSniffer" ]; then phpenv config-add /tmp/xdebug.ini; fi script: DRUPAL_DIR=$DRUPAL_DIR MODULE_DIR=$MODULE_DIR $MODULE_DIR/scripts/travis-ci/run-test.sh $TEST_SUITE From 5490c25fdb183b9ada3561828df4389e131ed9c3 Mon Sep 17 00:00:00 2001 From: Maarten Segers Date: Tue, 14 May 2019 16:48:34 +0200 Subject: [PATCH 19/22] Added configuration for PHP Mess Detector Source: https://raw.githubusercontent.com/digipolisgent/ci_config-files-and-scripts/master/php/drupal8/.phpmd.xml --- .phpmd.xml | 39 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 39 insertions(+) create mode 100644 .phpmd.xml diff --git a/.phpmd.xml b/.phpmd.xml new file mode 100644 index 000000000..738d13e09 --- /dev/null +++ b/.phpmd.xml @@ -0,0 +1,39 @@ + + + + A PMD Ruleset for Drupal coding standards. + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + From 05bd608198ffb4c36659f248ed48ad032dded71c Mon Sep 17 00:00:00 2001 From: Maarten Segers Date: Tue, 14 May 2019 16:49:05 +0200 Subject: [PATCH 20/22] Update .codeclimate.yml --- .codeclimate.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.codeclimate.yml b/.codeclimate.yml index be4d90906..fa19baa4b 100644 --- a/.codeclimate.yml +++ b/.codeclimate.yml @@ -2,8 +2,6 @@ version: "2" prepare: fetch: - - url: "https://raw.githubusercontent.com/digipolisgent/ci_config-files-and-scripts/master/php/drupal8/.phpmd.xml" - path: ".phpmd.xml" - url: "https://git.drupalcode.org/project/drupal/raw/8.7.x/.csslintrc" path: ".csslintrc" - url: "https://git.drupalcode.org/project/drupal/raw/8.7.x/core/.eslintrc.json" From 47b72f006b13a9ab9df5fc53714e3d9395b621cd Mon Sep 17 00:00:00 2001 From: Maarten Segers Date: Fri, 17 May 2019 19:23:42 +0200 Subject: [PATCH 21/22] Disable PHP Mess Detection --- .codeclimate.yml | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/.codeclimate.yml b/.codeclimate.yml index fa19baa4b..abe115dfc 100644 --- a/.codeclimate.yml +++ b/.codeclimate.yml @@ -42,14 +42,7 @@ plugins: standard: "Drupal,DrupalPractice" file_extensions: "php,inc,module,install" phpmd: - enabled: true - config: - file_extensions: - - php - - inc - - module - - install - rulesets: ".phpmd.xml" + enabled: false csslint: enabled: true eslint: From 8fbf55487799afcf70aa81bf485cff6210e73c26 Mon Sep 17 00:00:00 2001 From: Maarten Segers Date: Fri, 17 May 2019 19:24:00 +0200 Subject: [PATCH 22/22] Delete .phpmd.xml --- .phpmd.xml | 39 --------------------------------------- 1 file changed, 39 deletions(-) delete mode 100644 .phpmd.xml diff --git a/.phpmd.xml b/.phpmd.xml deleted file mode 100644 index 738d13e09..000000000 --- a/.phpmd.xml +++ /dev/null @@ -1,39 +0,0 @@ - - - - A PMD Ruleset for Drupal coding standards. - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -