Skip to content
This repository has been archived by the owner on Aug 18, 2024. It is now read-only.

Removed @expectedException tags #605

Merged
merged 2 commits into from
Jan 29, 2020
Merged

Removed @expectedException tags #605

merged 2 commits into from
Jan 29, 2020

Conversation

kbrodej
Copy link
Contributor

@kbrodej kbrodej commented Jan 7, 2020

Fix for #548

pfrenssen
pfrenssen approved these changes Jan 29, 2020
View reviewed changes
Copy link
Contributor

@pfrenssen pfrenssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, thanks so much for this PR!

I like how the $this->expectException() calls are always placed right before the line that triggers the exception, it makes the code "exceptionally" easy to follow 😁 👍

phpcs-ruleset.xml.dist Outdated Show resolved Hide resolved
@pfrenssen pfrenssen merged commit 488b701 into Gizra:8.x-1.x Jan 29, 2020
@pfrenssen pfrenssen mentioned this pull request Jan 29, 2020
Closed
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pfrenssen pfrenssen pfrenssen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kbrodej @pfrenssen