Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL regex fails for valid URL #151

Closed
Barabazs opened this issue Oct 12, 2024 · 1 comment · Fixed by #152
Closed

URL regex fails for valid URL #151

Barabazs opened this issue Oct 12, 2024 · 1 comment · Fixed by #152

Comments

@Barabazs
Copy link
Contributor

Barabazs commented Oct 12, 2024

The current regex fails to validate 'https://hackmd.io/@abdelhamid/ethereum-alignment' as a valid URL.

I would suggest to replace the regex with a library like https://validators.readthedocs.io or fix the regex pattern. It might also be a good idea to add a --source=url type of option in the CLI.

PS: I can create a PR if you agree.

@GjjvdBurg
Copy link
Owner

Thanks for reporting this @Barabazs! Both of those sound like great ideas, and I'd welcome your PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants