Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gladys Plus: Increase ackTimeout to 60s #2128

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

Pierre-Gilles
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles commented Oct 11, 2024

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Increase ackTimeout to 60s because some instances were disconnecting because of the low timeout

Copy link

Deploying gladys-plus with  Cloudflare Pages  Cloudflare Pages

Latest commit: 829557a
Status: ✅  Deploy successful!
Preview URL: https://7162538b.gladys-plus.pages.dev
Branch Preview URL: https://increase-ack-timeout-gladys.gladys-plus.pages.dev

View logs

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.48%. Comparing base (e0e2d37) to head (829557a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2128   +/-   ##
=======================================
  Coverage   98.48%   98.48%           
=======================================
  Files         867      867           
  Lines       14187    14187           
=======================================
  Hits        13972    13972           
  Misses        215      215           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

relativeci bot commented Oct 11, 2024

#2765 Bundle Size — 10.24MiB (0%).

829557a(current) vs e0e2d37 master#2763(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  no changes
                 Current
#2765
     Baseline
#2763
No change  Initial JS 5.54MiB 5.54MiB
No change  Initial CSS 304.63KiB 304.63KiB
No change  Cache Invalidation 54.02% 54.02%
No change  Chunks 51 51
No change  Assets 171 171
No change  Modules 1492 1492
No change  Duplicate Modules 21 21
No change  Duplicate Code 0.83% 0.83%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  no changes
                 Current
#2765
     Baseline
#2763
No change  JS 7.32MiB 7.32MiB
No change  IMG 2.48MiB 2.48MiB
No change  CSS 321.42KiB 321.42KiB
No change  Fonts 93.55KiB 93.55KiB
No change  Other 17.62KiB 17.62KiB
No change  HTML 13.58KiB 13.58KiB

Bundle analysis reportBranch increase-ack-timeout-gladys-plusProject dashboard


Generated by RelativeCIDocumentationReport issue

@Pierre-Gilles Pierre-Gilles merged commit bc41ef3 into master Oct 11, 2024
10 checks passed
@Pierre-Gilles Pierre-Gilles deleted the increase-ack-timeout-gladys-plus branch October 11, 2024 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant