Feature/user management #24
Conversation
silvareal
commented
Nov 18, 2021
•
silvareal
commented
- user login
- User registration
- user logout
- user reset password
- user forgot password
- social auth login (Facebook or google)
- replace IP's with user instance
|
Looking good 🙌🏿 |
| from typing import List | ||
| import contextlib | ||
| import logging | ||
|
|
| @@ -0,0 +1,28 @@ | |||
| """autho2 | |||
There was a problem hiding this comment.
All the new migration files look incredibly sus
From my understanding, user table should be created in an upgrade and those foreign keys added to necessary tables
Then downgrade will consist of deleting the foreign keys and the table
I can't see the new user id foreign key field getting added to the download and referral tables
There was a problem hiding this comment.
I've not been able to successfully migrate this, we could possibly check this out together later... having issues with FK and i haven't worked on it since the last time we spoke.
| db_rating_query = get_rating_by_schema(db, schemas.IndexedRating( | ||
| ip_address=spec_rating.ip_address, movie_id=movie.id)) | ||
| user_id=spec_rating.user_I, movie_id=movie.id)) |
There was a problem hiding this comment.
user_I instead of user_id I suppose
|
|
||
| id = Column(Integer, primary_key=True, index=True) | ||
| movie_id = Column(Integer, ForeignKey("movies.id")) | ||
| ip_address = Column(String) | ||
| user_id = Column(Integer, ForeignKey("user.id")) | ||
| user_id = Column(ForeignKey("user.id")) |
There was a problem hiding this comment.
user_id here is just foreign key?
Any reason why the one above is a GUID?
| @@ -0,0 +1,28 @@ | |||
| """autho2 | |||
| @@ -0,0 +1,5 @@ | |||
| { | |||
There was a problem hiding this comment.
Also add the .DS_Store and clean them up
| @@ -0,0 +1,4 @@ | |||
| GOOGLE_CLIENT_ID=553026630658-ed4e19reiffffm0kihn5lh6ln3d4g.apps.googleusercontent.com | |||
There was a problem hiding this comment.
I hope this is actually a fake accoutn.
|
Yes, sample , not real
…On Mon, 22 Nov 2021 at 5:55 PM, Mmadu Manasseh ***@***.***> wrote:
***@***.**** commented on this pull request.
Ms
------------------------------
In .vscode/settings.json
<#24 (comment)>:
> @@ -0,0 +1,5 @@
+{
Add this file to .gitignore
------------------------------
In .env.example
<#24 (comment)>:
> @@ -0,0 +1,4 @@
+GOOGLE_CLIENT_ID=553026630658-ed4e19reiffffm0kihn5lh6ln3d4g.apps.googleusercontent.com
I hope this is actually a fake accoutn.
------------------------------
In .vscode/settings.json
<#24 (comment)>:
> @@ -0,0 +1,5 @@
+{
Also add the .DS_Store and clean them up
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#24 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGLSGL2STFESIDMNCVS2ZTDUNJYYJANCNFSM5IJNBRJQ>
.
|
