From 082715ba30c36e4f9394def4a82b3a6fbd524430 Mon Sep 17 00:00:00 2001 From: Brendan Kenny Date: Wed, 6 Nov 2019 18:41:52 -0500 Subject: [PATCH] feedback --- build/build-bundle.js | 2 +- clients/devtools-entry.js | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/build/build-bundle.js b/build/build-bundle.js index 6e2f84aef8ed..1b93a8449560 100644 --- a/build/build-bundle.js +++ b/build/build-bundle.js @@ -88,7 +88,7 @@ async function browserifyFile(entryPath, distPath) { } // Expose the audits, gatherers, and computed artifacts so they can be dynamically loaded. - // Exposed path relative to lighthouse-core/config/config-helpers.js (where loading occurs). + // Exposed path must be a relative path from lighthouse-core/config/config-helpers.js (where loading occurs). const corePath = './lighthouse-core/'; const driverPath = `${corePath}gather/`; audits.forEach(audit => { diff --git a/clients/devtools-entry.js b/clients/devtools-entry.js index 395c2ccd0a74..1b352b58fa42 100644 --- a/clients/devtools-entry.js +++ b/clients/devtools-entry.js @@ -14,8 +14,8 @@ const {registerLocaleData, lookupLocale} = require('../lighthouse-core/lib/i18n/ /** * Return a version of the default config, filtered to only run the specified - * categories. Exclude `lighthouse-plugin-publisher-ads` to not include the - * plugin in the run. + * categories. If `lighthouse-plugin-publisher-ads` is in the list of + * `categoryIDs` the plugin will also be run. * @param {Array} categoryIDs * @return {LH.Config.Json} */