From 41dd404cbf863e4bb8bdd83ee3e70615b6d4db05 Mon Sep 17 00:00:00 2001 From: Connor Clark Date: Thu, 24 Oct 2019 14:52:08 -0700 Subject: [PATCH] tests(viewer): don't override puppeteer's chromium (#9877) --- .travis.yml | 8 ++++---- lighthouse-viewer/test/viewer-test-pptr.js | 1 - 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/.travis.yml b/.travis.yml index f5cf3ae9acb6..2cbbbf2b5bc4 100644 --- a/.travis.yml +++ b/.travis.yml @@ -17,10 +17,10 @@ cache: install: # Ensure we have the latest Chrome stable. - google-chrome-stable --version - # if our e2e tests fail in the future it might be that we are not compatible - # with the latest puppeteer api so we probably need to run on chromimum - # @see https://github.com/GoogleChrome/lighthouse/pull/4640/files#r171425004 - - export PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=1 + # We used to set PUPPETEER_SKIP_CHROMIUM_DOWNLOAD, but we don't want to anymore. + # Explicitly unset b/c environment variables seem to linger in travis. + # see https://github.com/GoogleChrome/lighthouse/pull/9877#discussion_r338389765 + - unset PUPPETEER_SKIP_CHROMIUM_DOWNLOAD - yarn --frozen-lockfile before_script: # see comment above about puppeteer diff --git a/lighthouse-viewer/test/viewer-test-pptr.js b/lighthouse-viewer/test/viewer-test-pptr.js index 5781fd63e4ec..f504c3609d9b 100644 --- a/lighthouse-viewer/test/viewer-test-pptr.js +++ b/lighthouse-viewer/test/viewer-test-pptr.js @@ -62,7 +62,6 @@ describe('Lighthouse Viewer', () => { // start puppeteer browser = await puppeteer.launch({ headless: true, - executablePath: process.env.CHROME_PATH, }); viewerPage = await browser.newPage(); viewerPage.on('pageerror', pageError => pageErrors.push(pageError));