From 89a897324570b9eb332ccf356518e6779c7dc183 Mon Sep 17 00:00:00 2001 From: Connor Clark Date: Mon, 9 May 2022 11:18:24 -0700 Subject: [PATCH] misc: modify cherry-picked commits to pass CI --- lighthouse-cli/test/smokehouse/version-check-test.js | 1 + lighthouse-cli/test/smokehouse/version-check.js | 1 + .../test/fraggle-rock/scenarios/api-test-pptr.js | 8 ++++---- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/lighthouse-cli/test/smokehouse/version-check-test.js b/lighthouse-cli/test/smokehouse/version-check-test.js index d73963ea6c3a..3825ca053f0a 100644 --- a/lighthouse-cli/test/smokehouse/version-check-test.js +++ b/lighthouse-cli/test/smokehouse/version-check-test.js @@ -3,6 +3,7 @@ * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ +'use strict'; import {chromiumVersionCheck, compareVersions} from './version-check.js'; diff --git a/lighthouse-cli/test/smokehouse/version-check.js b/lighthouse-cli/test/smokehouse/version-check.js index 9340527bc8dd..f89c22bf3d79 100644 --- a/lighthouse-cli/test/smokehouse/version-check.js +++ b/lighthouse-cli/test/smokehouse/version-check.js @@ -3,6 +3,7 @@ * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ +'use strict'; /** * @fileoverview Compares chromium version strings: 103.0.5017.0 diff --git a/lighthouse-core/test/fraggle-rock/scenarios/api-test-pptr.js b/lighthouse-core/test/fraggle-rock/scenarios/api-test-pptr.js index af994a6d311b..362a655e58fb 100644 --- a/lighthouse-core/test/fraggle-rock/scenarios/api-test-pptr.js +++ b/lighthouse-core/test/fraggle-rock/scenarios/api-test-pptr.js @@ -82,9 +82,9 @@ describe('Fraggle Rock API', () => { notApplicableAudits, } = getAuditsBreakdown(lhr); // TODO(FR-COMPAT): This assertion can be removed when full compatibility is reached. - expect(auditResults.length).toMatchInlineSnapshot(`45`); + expect(auditResults.length).toMatchInlineSnapshot(`46`); - expect(notApplicableAudits.length).toMatchInlineSnapshot(`5`); + expect(notApplicableAudits.length).toMatchInlineSnapshot(`6`); expect(notApplicableAudits.map(audit => audit.id)).not.toContain('server-response-time'); expect(notApplicableAudits.map(audit => audit.id)).not.toContain('total-blocking-time'); @@ -129,9 +129,9 @@ describe('Fraggle Rock API', () => { if (!result) throw new Error('Lighthouse failed to produce a result'); const {auditResults, erroredAudits, notApplicableAudits} = getAuditsBreakdown(result.lhr); - expect(auditResults.length).toMatchInlineSnapshot(`45`); + expect(auditResults.length).toMatchInlineSnapshot(`46`); - expect(notApplicableAudits.length).toMatchInlineSnapshot(`19`); + expect(notApplicableAudits.length).toMatchInlineSnapshot(`20`); expect(notApplicableAudits.map(audit => audit.id)).toContain('server-response-time'); expect(notApplicableAudits.map(audit => audit.id)).not.toContain('total-blocking-time');