core: always run axe gatherer last (#8216)

GoogleChrome · Apr 12, 2019 · 9823a5a · 9823a5a
1 parent 2553a24
commit 9823a5a
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 4 deletions.
diff --git a/lighthouse-cli/test/cli/__snapshots__/index-test.js.snap b/lighthouse-cli/test/cli/__snapshots__/index-test.js.snap
@@ -1081,9 +1081,6 @@ Object {
         Object {
           "path": "chrome-console-messages",
         },
-        Object {
-          "path": "accessibility",
-        },
         Object {
           "path": "anchor-elements",
         },
@@ -1132,6 +1129,9 @@ Object {
         Object {
           "path": "seo/tap-targets",
         },
+        Object {
+          "path": "accessibility",
+        },
       ],
       "networkQuietThresholdMs": 1000,
       "passName": "defaultPass",

diff --git a/lighthouse-cli/test/fixtures/byte-efficiency/tester.html b/lighthouse-cli/test/fixtures/byte-efficiency/tester.html
@@ -144,6 +144,7 @@ <h2>Byte efficiency tester page</h2>
   <div class="onscreen" style="width: 30px; height: 30px; background: 25% 50% url(lighthouse-480x320.jpg?sprite);"></div>
   <div class="onscreen" style="width: 30px; height: 30px; background: 50% 50% url(lighthouse-480x320.jpg?sprite);"></div>
   <div class="onscreen" style="width: 30px; height: 30px; background: 75% 50% url(lighthouse-480x320.jpg?sprite);"></div>
+  <p style="background: blue;">Add some text here so axe will scroll to the bottom</p>
 </div>
 
 <template id="lazily-loaded-image">

diff --git a/lighthouse-cli/test/smokehouse/byte-config.js b/lighthouse-cli/test/smokehouse/byte-config.js
@@ -12,6 +12,7 @@ module.exports = {
   extends: 'lighthouse:full',
   settings: {
     onlyAudits: [
+      'accesskeys', // run axe on the page since we've had problems with interactions
       'network-requests',
       'offscreen-images',
       'uses-webp-images',

diff --git a/lighthouse-core/config/default-config.js b/lighthouse-core/config/default-config.js
@@ -102,7 +102,6 @@ const defaultConfig = {
       'viewport-dimensions',
       'runtime-exceptions',
       'chrome-console-messages',
-      'accessibility',
       'anchor-elements',
       'image-elements',
       'link-elements',
@@ -119,6 +118,8 @@ const defaultConfig = {
       'seo/embedded-content',
       'seo/robots-txt',
       'seo/tap-targets',
+      // Always run axe last because it scrolls the page down to the bottom
+      'accessibility',
     ],
   },
   {