pr feedback

GoogleChrome · Apr 13, 2019 · f8a3082 · f8a3082
1 parent 62e00b6
commit f8a3082
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/lighthouse-core/report/html/report-styles.css b/lighthouse-core/report/html/report-styles.css
@@ -112,7 +112,7 @@
   --score-title-line-height-big: 36px;
   --score-title-line-height: 26px;
   --section-padding: 40px;
-  --setting-title-min-width: 220px;
+  --env-name-min-width: 220px;
   --topbar-padding: 0 8px;
 
   --pass-icon-url: url('data:image/svg+xml;utf8,<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 48 48"><title>check</title><path fill="%23178239" d="M24 4C12.95 4 4 12.95 4 24c0 11.04 8.95 20 20 20 11.04 0 20-8.96 20-20 0-11.05-8.96-20-20-20zm-4 30L10 24l2.83-2.83L20 28.34l15.17-15.17L38 16 20 34z"/></svg>');
@@ -155,7 +155,7 @@
     --score-title-line-height-big: 26px;
     --score-title-line-height: 20px;
     --section-padding: 24px;
-    --setting-title-min-width: 120px;
+    --env-name-min-width: 120px;
     --topbar-height: 32px;
   }
 

diff --git a/lighthouse-core/report/html/templates.html b/lighthouse-core/report/html/templates.html
@@ -521,7 +521,6 @@
     }
     .lh-env__items {
       padding-left: 16px;
-      margin-bottom: var(--audits-margin-bottom);
       margin: 0 0 var(--audits-margin-bottom);
       padding: 0;
     }
@@ -535,8 +534,8 @@
     }
     span.lh-env__name {
       font-weight: bold;
-      min-width: var(--setting-title-min-width);
-      flex: .5;
+      min-width: var(--env-name-min-width);
+      flex: 0.5;
       padding: 0 8px;
     }
     span.lh-env__description {