Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TTFB Audit followup #2192

Closed
paulirish opened this issue May 9, 2017 · 6 comments
Closed

TTFB Audit followup #2192

paulirish opened this issue May 9, 2017 · 6 comments

Comments

@paulirish
Copy link
Member

Forking from #2126

@wardpeet added:

I had a few changes ready to go, was fixing the details export of audit and cleaning up the criticalRequestChains but I can open an extra PR just for that 😄

i am also seeing this in the new report
image

and this in the old one:
image

@ebidel
Copy link
Contributor

ebidel commented May 9, 2017

Is "details export" adding a details rendering to the audit? FYI, I'm working on a criticalRequestChains details renderer.

@paulirish
Copy link
Member Author

i think so, but cc @wardpeet to be sure.

it'll just be a basic table renderer.

i'm working on a criticalRequestChains details renderer.

awesome.

@paulirish
Copy link
Member Author

Additional for @wardpeet: rename time-to-firstbyte to time-to-first-byte

@wardpeet
Copy link
Collaborator

wardpeet commented May 9, 2017

I was looking into the gatherer as @patrickhulce mentioned:

I was thinking just expose as a flattened property of the existing computed artifact so we don't bother with the computation twice although if you're feeling fancy we could refactor the existing one to call requestCriticalRequests and then build the tree :)

@wardpeet
Copy link
Collaborator

Just need a rebase and #2231 is ready.

Some records don't have _timing so I ignore them

@brendankenny
Copy link
Member

closed by #2231

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants