Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lighthouse treats "shrink-to-fit" property in meta-tag "viewport" as invalid #2474

Closed
zhirzh opened this issue Jun 9, 2017 · 15 comments
Closed

Comments

@zhirzh
Copy link

zhirzh commented Jun 9, 2017

In lighthouse audits,
this will pass:
<meta name="viewport" content="width=device-width, initial-scale=1">
this will fail:
<meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no">
with message Invalid properties found: {"shrink-to-fit":"no"}.

@patrickhulce
Copy link
Collaborator

patrickhulce commented Jun 9, 2017

Thanks for the report @zhirzh! Looks like our dependency for metaviewport parsing hasn't been updated in quite some time.

@zhirzh
Copy link
Author

zhirzh commented Jun 9, 2017

@patrickhulce that's not even my handle 😂

@patrickhulce
Copy link
Collaborator

patrickhulce commented Jun 9, 2017

oops 😆 fixed! haha sorry for the spam other similarly named LH-contributor :)

@evenstensberg
Copy link
Contributor

What should we do to chase this down?

@patrickhulce
Copy link
Collaborator

@ev1stensberg since that package doesn't seem very well maintained, we should probably add a temporary workaround to ignore shrink-to-fit in the audit for now

In the long term we'll need to decide if we want to...

  • work with the owner to get a fix in place and published
  • bring it into third_party and fix
  • drop the package and parse the values ourselves

@evenstensberg
Copy link
Contributor

I can work on long term if you want to, better fix now than never :)

@hmelenok
Copy link
Contributor

hmelenok commented Aug 4, 2017

@patrickhulce i fix it for you, guys please review it dontcallmedom/metaviewport-parser/pull/4

@hmelenok
Copy link
Contributor

hmelenok commented Aug 7, 2017

@patrickhulce /pull/2863 with updated version

@paulirish
Copy link
Member

fixed by #2863

@jamesvclements
Copy link

jamesvclements commented Sep 30, 2017

Hey I'm still getting this as a problem on the chrome extension:
image
The viewport audit has a ✅ but is considered failed w/ the invalid shrink-to-fit property.
I ran it on the default build of create-react-app

@PatNeedham
Copy link

I'm still getting that same problem on the chrome extension @jamesvclements is referring to as well, ran on the default build of create-react-app.

@evenstensberg
Copy link
Contributor

Needs reinvestigation @patrickhulce

@brendankenny
Copy link
Member

I think this is due to the release of the extension lagging behind (it's still on 2.3.0). We're hoping to do a release of 2.5.0 on all platforms early next week.

@Foorack
Copy link

Foorack commented Nov 10, 2017

Any update on this? I am still experiencing this in Chrome 62.

@patrickhulce
Copy link
Collaborator

@Foorack this was fixed on august 7, use Chrome Canary, the CLI, or the extension for latest LH version with the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants