-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lighthouse treats "shrink-to-fit" property in meta-tag "viewport" as invalid #2474
Comments
Thanks for the report @zhirzh! Looks like our dependency for metaviewport parsing hasn't been updated in quite some time. |
@patrickhulce that's not even my handle 😂 |
oops 😆 fixed! haha sorry for the spam other similarly named LH-contributor :) |
What should we do to chase this down? |
@ev1stensberg since that package doesn't seem very well maintained, we should probably add a temporary workaround to ignore In the long term we'll need to decide if we want to...
|
I can work on long term if you want to, better fix now than never :) |
@patrickhulce i fix it for you, guys please review it dontcallmedom/metaviewport-parser/pull/4 |
@patrickhulce /pull/2863 with updated version |
fixed by #2863 |
Hey I'm still getting this as a problem on the chrome extension: |
I'm still getting that same problem on the chrome extension @jamesvclements is referring to as well, ran on the default build of create-react-app. |
Needs reinvestigation @patrickhulce |
I think this is due to the release of the extension lagging behind (it's still on 2.3.0). We're hoping to do a release of 2.5.0 on all platforms early next week. |
Any update on this? I am still experiencing this in Chrome 62. |
@Foorack this was fixed on august 7, use Chrome Canary, the CLI, or the extension for latest LH version with the fix |
In lighthouse audits,
this will pass:
<meta name="viewport" content="width=device-width, initial-scale=1">
this will fail:
<meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no">
with message
Invalid properties found: {"shrink-to-fit":"no"}.
The text was updated successfully, but these errors were encountered: