Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A11y i18n #7010

Closed
exterkamp opened this issue Jan 14, 2019 · 8 comments · Fixed by #7113
Closed

A11y i18n #7010

exterkamp opened this issue Jan 14, 2019 · 8 comments · Fixed by #7113
Assignees
Labels
bug i18n internationalization thangs

Comments

@exterkamp
Copy link
Member

Provide the steps to reproduce

As of #7008 there are some gaps in a11y translation:

  • title, and category description
    image
  • Manual Audits
    image
@exterkamp exterkamp added bug i18n internationalization thangs labels Jan 14, 2019
@paulirish
Copy link
Member

As of #7008 there are some gaps in a11y translation:

We could bring back https://github.com/GoogleChrome/lighthouse/pull/5726/files#diff-4bcfedf0736e1cd08b26fe659537ad90 to help avoid this.

@patrickhulce
Copy link
Collaborator

@brendankenny
Copy link
Member

We could bring back https://github.com/GoogleChrome/lighthouse/pull/5726/files#diff-4bcfedf0736e1cd08b26fe659537ad90 to help avoid this.

wait, is that to make it easier to spot when we've missed some strings when manually testing? Is it that different than just loading in russian and looking for english?

@patrickhulce
Copy link
Collaborator

@brendankenny you have to wait for the translations to come back though, that bit was us programmatically generating it so you could notice as you're going.

@paulirish
Copy link
Member

I also want to comment in this thread right now.

@brendankenny
Copy link
Member

We need the script to load in the en-XA to see that it's bad before we send it to be translated afaik.

Cool. But I do predict the exact same pace of people actually loading another locale to check if we've missed something :P

@exterkamp
Copy link
Member Author

Well now I have to leave a comment.

@brendankenny
Copy link
Member

more comments: can we turn this into an i18n phase 2 issue and close #5719? Or turn it into a en-XA and make a phase 2 issue elsewhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug i18n internationalization thangs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants
@paulirish @brendankenny @patrickhulce @exterkamp and others