-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A11y i18n #7010
Comments
We could bring back https://github.com/GoogleChrome/lighthouse/pull/5726/files#diff-4bcfedf0736e1cd08b26fe659537ad90 to help avoid this. |
Huzzah!! Yes please :D |
wait, is that to make it easier to spot when we've missed some strings when manually testing? Is it that different than just loading in russian and looking for english? |
@brendankenny you have to wait for the translations to come back though, that bit was us programmatically generating it so you could notice as you're going. |
I also want to comment in this thread right now. |
Cool. But I do predict the exact same pace of people actually loading another locale to check if we've missed something :P |
Well now I have to leave a comment. |
more comments: can we turn this into an i18n phase 2 issue and close #5719? Or turn it into a |
Provide the steps to reproduce
As of #7008 there are some gaps in a11y translation:
The text was updated successfully, but these errors were encountered: