i18n: fix multi-directory collision checking #12698
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
commented
Jun 25, 2021
| } | ||
|
|
||
| if (collisions > 0) { | ||
| console.log(`MEANING COLLISION: ${collisions} string(s) have the same content.`); | ||
| assert.equal(collisions, 30, `The number of duplicate strings have changed, update this assertion if that is expected, or reword strings. Collisions: ${collisionStrings.join('\n')}`); | ||
| assert.equal(collisions, 32, `The number of duplicate strings have changed, update this assertion if that is expected, or reword strings. Collisions: ${collisionStrings.join('\n')}`); |
There was a problem hiding this comment.
this is +2 for the collision between "lighthouse-treemap/app/src/util.js | tableColumnName" and "lighthouse-core/lib/i18n/i18n.js | columnName" we didn't add in #12441
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this was my TODO in https://github.com/GoogleChrome/lighthouse/pull/12441/files#r630521367 that I forgot (once again proving you should never leave a TODO to do an issue's job :)
The fix is really simple but as I was opening github to open this PR I just noticed @connorjclark's #12697 🤔