update webapp-install-banner.js helpText #2622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -38,7 +38,9 @@ class WebappInstallBanner extends MultiCheckAudit { | |||
| category: 'PWA', | |||
| name: 'webapp-install-banner', | |||
| description: 'User can be prompted to Install the Web App', | |||
| helpText: 'While users can manually add your site to their homescreen, the [prompt (aka app install banner)](https://developers.google.com/web/fundamentals/engage-and-retain/app-install-banners/) will proactively prompt the user to install the app if the various requirements are met and the user has moderate engagement with your site.', | |||
| helpText: 'Browsers can proactively prompt users to add your app to their homescreen. ' + | |||
| 'Users who add apps to their homescreen engage those apps more. ' + | |||
There was a problem hiding this comment.
"engage with those apps more" maybe?
There was a problem hiding this comment.
Or.. maybe something like.
A homescreen icon leads to higher engagement.
There was a problem hiding this comment.
How about:
Browsers can proactively prompt users to add your app to their homescreen, which can lead to higher engagement.
kaycebasques
force-pushed
the
docs-installprompt
branch
from
0fb79c3 to
5601a0f
Compare
kaycebasques
force-pushed
the
docs-installprompt
branch
from
5601a0f to
7d584ac
Compare
|
henlo @patrickhulce and @paulirish my ol frens, plz look at updated text |
patrickhulce
approved these changes
Jul 10, 2017
paulirish
approved these changes
Jul 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.