Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc(package): scripts don't require "--" for options to be forwarded #4437

Merged
merged 1 commit into from
Feb 6, 2018
Merged

misc(package): scripts don't require "--" for options to be forwarded #4437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lighthouse-cli/test/smokehouse/a11y/run-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ sleep 0.5s
config="lighthouse-cli/test/smokehouse/a11y/a11y-config.js"
expectations="lighthouse-cli/test/smokehouse/a11y/expectations.js"

yarn smokehouse -- --config-path=$config --expectations-path=$expectations
yarn smokehouse --config-path=$config --expectations-path=$expectations
exit_code=$?

# kill test servers
Expand Down
2 changes: 1 addition & 1 deletion lighthouse-cli/test/smokehouse/byte-efficiency/run-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ sleep 0.5s
config="lighthouse-cli/test/smokehouse/byte-config.js"
expectations="lighthouse-cli/test/smokehouse/byte-efficiency/expectations.js"

yarn smokehouse -- --config-path=$config --expectations-path=$expectations
yarn smokehouse --config-path=$config --expectations-path=$expectations
exit_code=$?

# kill test servers
Expand Down
2 changes: 1 addition & 1 deletion lighthouse-cli/test/smokehouse/dobetterweb/run-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ config="lighthouse-cli/test/smokehouse/dbw-config.js"
expectations="lighthouse-cli/test/smokehouse/dobetterweb/dbw-expectations.js"

# run smoketest on DBW test page.
yarn smokehouse -- --config-path=$config --expectations-path=$expectations
yarn smokehouse --config-path=$config --expectations-path=$expectations
exit_code=$?

# kill test servers
Expand Down
2 changes: 1 addition & 1 deletion lighthouse-cli/test/smokehouse/offline-local/run-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ config="lighthouse-cli/test/smokehouse/offline-config.js"
expectations="lighthouse-cli/test/smokehouse/offline-local/offline-expectations.js"

# run smoketest, expecting results found in offline-expectations
yarn smokehouse -- --config-path=$config --expectations-path=$expectations
yarn smokehouse --config-path=$config --expectations-path=$expectations
exit_code=$?

# kill test servers
Expand Down
2 changes: 1 addition & 1 deletion lighthouse-cli/test/smokehouse/perf/run-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ sleep 0.5s
config="lighthouse-core/config/perf.json"
expectations="lighthouse-cli/test/smokehouse/perf/expectations.js"

yarn smokehouse -- --config-path=$config --expectations-path=$expectations
yarn smokehouse --config-path=$config --expectations-path=$expectations
exit_code=$?

# kill test servers
Expand Down
2 changes: 1 addition & 1 deletion lighthouse-cli/test/smokehouse/redirects/run-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ config="lighthouse-cli/test/smokehouse/redirects-config.js"
expectations="lighthouse-cli/test/smokehouse/redirects/expectations.js"

# run smoketest, expecting results found in offline-expectations
yarn smokehouse -- --config-path=$config --expectations-path=$expectations
yarn smokehouse --config-path=$config --expectations-path=$expectations
exit_code=$?

# kill test servers
Expand Down
2 changes: 1 addition & 1 deletion lighthouse-cli/test/smokehouse/seo/run-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ sleep 0.5s
config="lighthouse-cli/test/smokehouse/seo-config.js"
expectations="lighthouse-cli/test/smokehouse/seo/expectations.js"

yarn smokehouse -- --config-path=$config --expectations-path=$expectations
yarn smokehouse --config-path=$config --expectations-path=$expectations
exit_code=$?

# kill test servers
Expand Down
2 changes: 1 addition & 1 deletion lighthouse-cli/test/smokehouse/tricky-ttci/run-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ sleep 0.5s
config="lighthouse-core/config/default.js"
expectations="lighthouse-cli/test/smokehouse/tricky-ttci/expectations.js"

yarn smokehouse -- --config-path=$config --expectations-path=$expectations
yarn smokehouse --config-path=$config --expectations-path=$expectations
exit_code=$?

# kill test servers
Expand Down
2 changes: 1 addition & 1 deletion lighthouse-core/scripts/compile-against-devtools.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ cd "$protocol_path" && git reset --hard && git fetch origin master && git checko
cd "$lhroot_path" || exit 1

# copy renderer and lh backgrond into this devtools checkout
yarn devtools -- "$frontend_path/front_end/"
yarn devtools "$frontend_path/front_end/"

#
# monkeypatch the audits2 module.json to include any new files we're added that aren't present
Expand Down
4 changes: 2 additions & 2 deletions lighthouse-core/scripts/roll-to-devtools.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,13 @@
# yarn devtools

# with a custom devtools front_end location:
# yarn devtools -- node_modules/temp-devtoolsfrontend/front_end/
# yarn devtools node_modules/temp-devtoolsfrontend/front_end/

chromium_dir="$HOME/chromium/src"

if [[ -n "$1" ]]; then
frontend_dir="$1"
else
else
frontend_dir="$chromium_dir/third_party/WebKit/Source/devtools/front_end"
fi

Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
"compile-devtools": "bash lighthouse-core/scripts/compile-against-devtools.sh",
"watch": "bash lighthouse-core/scripts/run-mocha.sh --watch",
"chrome": "node chrome-launcher/manual-chrome-launcher.js",
"fast": "yarn start -- --disable-device-emulation --disable-cpu-throttling --disable-network-throttling",
"fast": "yarn start --disable-device-emulation --disable-cpu-throttling --disable-network-throttling",
"smokehouse": "node lighthouse-cli/test/smokehouse/smokehouse.js",
"deploy-viewer": "cd lighthouse-viewer && gulp deploy",
"bundlesize": "bundlesize",
Expand Down