Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(compile): fix broken compile-devtools script #5234

Merged
merged 2 commits into from
May 16, 2018
Merged

tests(compile): fix broken compile-devtools script #5234

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93bc678
tests(compile): fix broken compile-devtools script
paulirish May 16, 2018
b23636d
.
paulirish May 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions lighthouse-core/scripts/compile-against-devtools.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
# usage
# yarn compile-devtools

set -x

# This the text here will override the renderer/ files in in the scripts[] array:
# https://github.com/ChromeDevTools/devtools-frontend/blob/master/front_end/audits2/module.json#L20
Expand All @@ -21,10 +22,13 @@ files_to_include="\"lighthouse\/renderer\/util.js\", \"lighthouse\/renderer\/dom

# paths
local_script_path="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
lhroot_path="$local_script_path/../../"
lhroot_path="$local_script_path/../.."
module_path="$lhroot_path/node_modules/lh-compile-devtools"

frontend_path="$lhroot_path/node_modules/temp-devtoolsfrontend"
protocol_path="$lhroot_path/node_modules/temp-devtoolsprotocol"
# extra deep frontend_path used because of the hardcoded os.pardir's here:
# https://github.com/ChromeDevTools/devtools-frontend/blob/157d472fd748/scripts/build/generate_protocol_externs.py#L39-L43
frontend_path="$module_path/two-more/almost-there/devtools-frontend"
protocol_path="$module_path/devtools-protocol"

# clone if they're not there
if [ ! -d "$frontend_path" ]; then
Expand All @@ -37,10 +41,15 @@ fi
# update to latest
cd "$frontend_path" && git reset --hard && git fetch origin master && git checkout --quiet --force origin/master
cd "$protocol_path" && git reset --hard && git fetch origin master && git checkout --quiet --force origin/master
# initialize the inspector_protocol submodule
git -C "$protocol_path" submodule update --init

# Copy it to location generate_protocol_externs.py will import the pdl module from
# https://github.com/ChromeDevTools/devtools-frontend/blob/157d472fd748/scripts/build/generate_protocol_externs.py#L39-L44
cp -fRp "$protocol_path/scripts/inspector_protocol" "$module_path"

cd "$lhroot_path" || exit 1

cd "$lhroot_path" || exit 1
# copy renderer and lh backgrond into this devtools checkout
yarn devtools "$frontend_path/front_end/"

Expand Down