Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(i18n): add [ICU Syntax] label to relevant message descriptions #5736

Merged
merged 1 commit into from
Jul 27, 2018
Merged

core(i18n): add [ICU Syntax] label to relevant message descriptions #5736

merged 1 commit into from
Jul 27, 2018

Conversation

paulirish
Copy link
Member

ref #5719

@paulirish paulirish mentioned this pull request Jul 27, 2018
Closed
24 tasks
brendankenny
brendankenny approved these changes Jul 27, 2018
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though we'll still have to go over the descriptions themselves to make sure they provide enough context (e.g. wtf is a "total Time to First Byte duration for the primary HTML response")

@paulirish paulirish merged commit 658a5e5 into master Jul 27, 2018
@paulirish paulirish deleted the icusyntaxlabel branch July 27, 2018 01:03
@paulirish paulirish mentioned this pull request Jul 27, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendankenny brendankenny brendankenny approved these changes

@patrickhulce patrickhulce Awaiting requested review from patrickhulce

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulirish @brendankenny