From 9dadf727cddbc958a9cd21fac474aa10890342c4 Mon Sep 17 00:00:00 2001 From: Paul Irish Date: Tue, 11 Dec 2018 11:54:06 -0800 Subject: [PATCH 1/2] core(lantern): drop node id from error message --- lighthouse-core/lib/dependency-graph/base-node.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lighthouse-core/lib/dependency-graph/base-node.js b/lighthouse-core/lib/dependency-graph/base-node.js index 78c6b24df886..f7313c78cae5 100644 --- a/lighthouse-core/lib/dependency-graph/base-node.js +++ b/lighthouse-core/lib/dependency-graph/base-node.js @@ -209,7 +209,7 @@ class BaseNode { } }); - if (!idToNodeMap.has(this.id)) throw new Error(`Cloned graph missing node ${this.id}`); + if (!idToNodeMap.has(this.id)) throw new Error(`Cloned graph missing node`); return idToNodeMap.get(this.id); } From 69e24b75d6e77d51515c139ceb9b796e4e63962e Mon Sep 17 00:00:00 2001 From: Connor Clark Date: Tue, 11 Dec 2018 15:05:54 -0800 Subject: [PATCH 2/2] Update base-node.js --- lighthouse-core/lib/dependency-graph/base-node.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lighthouse-core/lib/dependency-graph/base-node.js b/lighthouse-core/lib/dependency-graph/base-node.js index f7313c78cae5..705a4f498817 100644 --- a/lighthouse-core/lib/dependency-graph/base-node.js +++ b/lighthouse-core/lib/dependency-graph/base-node.js @@ -209,7 +209,7 @@ class BaseNode { } }); - if (!idToNodeMap.has(this.id)) throw new Error(`Cloned graph missing node`); + if (!idToNodeMap.has(this.id)) throw new Error('Cloned graph missing node'); return idToNodeMap.get(this.id); }