From 5b58340b494ba0e42c8e36cc507aabb642ffafe7 Mon Sep 17 00:00:00 2001 From: Brendan Kenny Date: Wed, 17 Jul 2019 15:02:30 -0700 Subject: [PATCH] tests(i18n): update canonical locale test for node 12.6 --- .travis.yml | 2 +- lighthouse-core/test/lib/i18n/locales-test.js | 3 ++- yarn.lock | 5 +++++ 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index a1aa6fe7c8d4..bb06f7155213 100644 --- a/.travis.yml +++ b/.travis.yml @@ -6,7 +6,7 @@ branches: matrix: include: - node_js: "10" - - node_js: "11" + - node_js: "12" if: head_branch IS blank AND branch = master dist: trusty cache: diff --git a/lighthouse-core/test/lib/i18n/locales-test.js b/lighthouse-core/test/lib/i18n/locales-test.js index eba944fa30cb..0dfab475117e 100644 --- a/lighthouse-core/test/lib/i18n/locales-test.js +++ b/lighthouse-core/test/lib/i18n/locales-test.js @@ -18,13 +18,14 @@ describe('locales', () => { const deprecatedCodes = { in: 'id', iw: 'he', + mo: 'ro', }; for (const locale of Object.keys(locales)) { const canonicalLocale = Intl.getCanonicalLocales(locale)[0]; const substitute = deprecatedCodes[locale]; assert.ok(locale === canonicalLocale || substitute === canonicalLocale, - `locale code '${locale}' not canonical`); + `locale code '${locale}' not canonical ('${canonicalLocale}' found instead)`); } // Deprecation subsitutes should be removed from the test if no longer used. diff --git a/yarn.lock b/yarn.lock index 5350a9a34b11..6d1d187a8cd4 100644 --- a/yarn.lock +++ b/yarn.lock @@ -4280,6 +4280,11 @@ is-windows@^1.0.2: resolved "https://registry.yarnpkg.com/is-windows/-/is-windows-1.0.2.tgz#d1850eb9791ecd18e6182ce12a30f396634bb19d" integrity sha512-eXK1UInq2bPmjyX6e3VHIzMLobc4J94i4AWn+Hpq3OU5KkrRC96OAcR3PRJ/pGu6m8TRnBHP9dkXQVsT/COVIA== +is-wsl@^1.1.0: + version "1.1.0" + resolved "https://registry.yarnpkg.com/is-wsl/-/is-wsl-1.1.0.tgz#1f16e4aa22b04d1336b66188a66af3c600c3a66d" + integrity sha1-HxbkqiKwTRM2tmGIpmrzxgDDpm0= + is-wsl@^2.1.0: version "2.1.0" resolved "https://registry.yarnpkg.com/is-wsl/-/is-wsl-2.1.0.tgz#94369bbeb2249ef07b831b1b08590e686330ccbb"