Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proto: update import hooks, obey line length #9595

Merged
merged 1 commit into from
Aug 22, 2019
Merged

proto: update import hooks, obey line length #9595

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions proto/lighthouse-result.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
syntax = "proto3";

// This comment required for Lightrider import compatibility # header

import "google/protobuf/struct.proto";
import "google/protobuf/timestamp.proto";
import "google/protobuf/wrappers.proto";

// This comment required for LightRider import compatibility
// This comment required for LightRider import compatibility # suffix
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't even


// Canonical list of errors created by Lighthouse.
enum LighthouseError {
Expand Down Expand Up @@ -142,7 +144,8 @@ message LighthouseResult {
// nullable list of strings
google.protobuf.Value only_categories = 3;

// How Lighthouse was run, e.g. from the Chrome extension or from the npm module
// How Lighthouse was run, e.g. from the Chrome extension or from the npm
// module
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...

string channel = 4;
}

Expand All @@ -154,8 +157,8 @@ message LighthouseResult {

// Message containing the performance timing data for the Lighthouse run
message Timing {

// Corresponds to: https://www.w3.org/TR/performance-timeline-2/#dom-performanceentry
// Corresponds to:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heavy heavy heavy sigh

// https://www.w3.org/TR/performance-timeline-2/#dom-performanceentry
message PerformanceEntry {
string name = 1;
string entry_type = 2;
Expand All @@ -169,7 +172,8 @@ message LighthouseResult {
// The total duration of Lighthouse's run
google.protobuf.DoubleValue total = 1;

// Corresponds to: https://www.w3.org/TR/performance-timeline-2/#idl-def-performanceentrylist
// Corresponds to:
// https://www.w3.org/TR/performance-timeline-2/#idl-def-performanceentrylist
repeated PerformanceEntry entries = 2;
}

Expand Down