Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workbox-range-requests will return a 206 response as-is #1721

Merged
merged 1 commit into from
Oct 18, 2018
Merged

workbox-range-requests will return a 206 response as-is #1721

merged 1 commit into from
Oct 18, 2018

Conversation

jeffposnick
Copy link
Contributor

R: @philipwalton
CC: @jakearchibald

Fixes #1720

This doesn't change much right now, but if and when the Cache Storage API starts generating HTTP 206 Partial Content responses, it ensures that workbox-range-requests usage wouldn't double-slice.

@jeffposnick jeffposnick added the Breaking Change Denotes a "major" semver change. label Oct 18, 2018
@jeffposnick jeffposnick added this to the v4 milestone Oct 18, 2018
@workbox-pr-bot
Copy link
Collaborator

PR-Bot Size Plugin

Changed File Sizes

File Before After Change GZipped
packages/workbox-background-sync/build/workbox-background-sync.prod.js 3.51 KB 3.10 KB -12% 1.39 KB 🎉
packages/workbox-broadcast-cache-update/build/workbox-broadcast-cache-update.prod.js 1.12 KB 1.88 KB +68% 940 B ☠️
packages/workbox-build/build/index.js 4.02 KB 3.64 KB -9% 1.36 KB
packages/workbox-cache-expiration/build/workbox-cache-expiration.prod.js 3.88 KB 3.15 KB -19% 1.29 KB 🎉
packages/workbox-cacheable-response/build/workbox-cacheable-response.prod.js 587 B 595 B +1% 351 B
packages/workbox-cli/build/app.js 6.76 KB 4.64 KB -31% 1.69 KB 🎉
packages/workbox-cli/build/bin.js 2.32 KB 1.16 KB -50% 580 B 🎉
packages/workbox-core/build/workbox-core.prod.js 7.47 KB 5.95 KB -20% 2.68 KB 🎉
packages/workbox-navigation-preload/build/workbox-navigation-preload.prod.js 660 B 668 B +1% 323 B
packages/workbox-precaching/build/workbox-precaching.prod.js 5.81 KB 5.24 KB -10% 2.21 KB
packages/workbox-range-requests/build/workbox-range-requests.prod.js 1.63 KB 1.53 KB -6% 765 B
packages/workbox-routing/build/workbox-routing.prod.js 2.87 KB 3.24 KB +13% 1.41 KB ☠️
packages/workbox-strategies/build/workbox-strategies.prod.js 5.09 KB 4.75 KB -7% 1.19 KB
packages/workbox-streams/build/workbox-streams.prod.js 1.57 KB 1.39 KB -11% 684 B 🎉
packages/workbox-sw/build/workbox-sw.js 1.50 KB 1.51 KB +1% 819 B
packages/workbox-webpack-plugin/build/generate-sw.js 8.04 KB 5.29 KB -34% 1.84 KB 🎉
packages/workbox-webpack-plugin/build/index.js 742 B 349 B -53% 255 B 🎉
packages/workbox-webpack-plugin/build/inject-manifest.js 10.30 KB 6.91 KB -33% 2.40 KB 🎉

New Files

File Size GZipped
packages/workbox-google-analytics/build/workbox-offline-ga.prod.js 1.84 KB 941 B

All File Sizes

View Table
File Before After Change GZipped
packages/workbox-background-sync/build/workbox-background-sync.prod.js 3.51 KB 3.10 KB -12% 1.39 KB 🎉
packages/workbox-broadcast-cache-update/build/workbox-broadcast-cache-update.prod.js 1.12 KB 1.88 KB +68% 940 B ☠️
packages/workbox-build/build/_types.js 41 B 41 B 0% 61 B
packages/workbox-build/build/index.js 4.02 KB 3.64 KB -9% 1.36 KB
packages/workbox-cache-expiration/build/workbox-cache-expiration.prod.js 3.88 KB 3.15 KB -19% 1.29 KB 🎉
packages/workbox-cacheable-response/build/workbox-cacheable-response.prod.js 587 B 595 B +1% 351 B
packages/workbox-cli/build/app.js 6.76 KB 4.64 KB -31% 1.69 KB 🎉
packages/workbox-cli/build/bin.js 2.32 KB 1.16 KB -50% 580 B 🎉
packages/workbox-core/build/workbox-core.prod.js 7.47 KB 5.95 KB -20% 2.68 KB 🎉
packages/workbox-google-analytics/build/workbox-offline-ga.prod.js 1.84 KB 941 B
packages/workbox-navigation-preload/build/workbox-navigation-preload.prod.js 660 B 668 B +1% 323 B
packages/workbox-precaching/build/workbox-precaching.prod.js 5.81 KB 5.24 KB -10% 2.21 KB
packages/workbox-range-requests/build/workbox-range-requests.prod.js 1.63 KB 1.53 KB -6% 765 B
packages/workbox-routing/build/workbox-routing.prod.js 2.87 KB 3.24 KB +13% 1.41 KB ☠️
packages/workbox-strategies/build/workbox-strategies.prod.js 5.09 KB 4.75 KB -7% 1.19 KB
packages/workbox-streams/build/workbox-streams.prod.js 1.57 KB 1.39 KB -11% 684 B 🎉
packages/workbox-sw/build/workbox-sw.js 1.50 KB 1.51 KB +1% 819 B
packages/workbox-webpack-plugin/build/generate-sw.js 8.04 KB 5.29 KB -34% 1.84 KB 🎉
packages/workbox-webpack-plugin/build/index.js 742 B 349 B -53% 255 B 🎉
packages/workbox-webpack-plugin/build/inject-manifest.js 10.30 KB 6.91 KB -33% 2.40 KB 🎉

Workbox Aggregate Size Plugin

9.72KB gzip'ed (65% of limit)
23.86KB uncompressed

philipwalton
philipwalton approved these changes Oct 18, 2018
View reviewed changes
Copy link
Member

@philipwalton philipwalton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks Jeff!

@jeffposnick jeffposnick merged commit cd5ef34 into next Oct 18, 2018
@jeffposnick jeffposnick deleted the range-requests-206-response branch October 18, 2018 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipwalton philipwalton philipwalton approved these changes

Assignees
No one assigned
Labels
Breaking Change Denotes a "major" semver change.
Projects
None yet
Milestone
v4
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffposnick @workbox-pr-bot @philipwalton