From 2e4b14a39b2cae1ee540362bb25d37cefafa5452 Mon Sep 17 00:00:00 2001 From: Jeff Posnick Date: Tue, 21 Apr 2020 13:39:47 -0400 Subject: [PATCH 1/2] Switch to node 10 --- .github/workflows/pull-request.yml | 3 +-- gulp-tasks/utils/build-node-package.js | 2 +- package.json | 2 +- packages/workbox-build/package.json | 2 +- packages/workbox-cli/package.json | 2 +- packages/workbox-webpack-plugin/package.json | 2 +- 6 files changed, 6 insertions(+), 7 deletions(-) diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index 5e7038c99..0b277bfa6 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -22,8 +22,7 @@ jobs: - name: Setup run: | - # Use `npm i` to work around https://github.com/npm/cli/issues/558 - npm i + npm ci gulp build - run: npx gulp test-node diff --git a/gulp-tasks/utils/build-node-package.js b/gulp-tasks/utils/build-node-package.js index 9894073e5..1cbb398fd 100644 --- a/gulp-tasks/utils/build-node-package.js +++ b/gulp-tasks/utils/build-node-package.js @@ -31,7 +31,7 @@ module.exports = (packagePath) => { ['@babel/preset-env', { targets: { // Change this when our minimum required node version changes. - node: '8.0', + node: '10.0', }, }], ], diff --git a/package.json b/package.json index 9c8fef781..d4f7040d9 100644 --- a/package.json +++ b/package.json @@ -1,7 +1,7 @@ { "name": "workbox", "engines": { - "node": ">=8.0.0" + "node": ">=10.0.0" }, "scripts": { "bot": "pr-bot", diff --git a/packages/workbox-build/package.json b/packages/workbox-build/package.json index 93bca8466..2da99c62e 100644 --- a/packages/workbox-build/package.json +++ b/packages/workbox-build/package.json @@ -12,7 +12,7 @@ "file manifest" ], "engines": { - "node": ">=8.0.0" + "node": ">=10.0.0" }, "author": "Google's Web DevRel Team", "license": "MIT", diff --git a/packages/workbox-cli/package.json b/packages/workbox-cli/package.json index 00c2e1e85..f24290b95 100644 --- a/packages/workbox-cli/package.json +++ b/packages/workbox-cli/package.json @@ -18,7 +18,7 @@ "build" ], "engines": { - "node": ">=8.0.0" + "node": ">=10.0.0" }, "scripts": { "prepublish": "gulp build-packages --package workbox-cli" diff --git a/packages/workbox-webpack-plugin/package.json b/packages/workbox-webpack-plugin/package.json index 4e294f0a7..4b2b88f1f 100644 --- a/packages/workbox-webpack-plugin/package.json +++ b/packages/workbox-webpack-plugin/package.json @@ -25,7 +25,7 @@ "build" ], "engines": { - "node": ">=8.0.0" + "node": ">=10.0.0" }, "dependencies": { "@babel/runtime": "^7.5.5", From 196b8c7486d984530dfb6622f818019850baafa0 Mon Sep 17 00:00:00 2001 From: Jeff Posnick Date: Tue, 21 Apr 2020 15:13:30 -0400 Subject: [PATCH 2/2] Win should use Node 10 --- .github/workflows/pull-request.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index 0b277bfa6..bf825cd87 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -18,7 +18,7 @@ jobs: - uses: actions/setup-node@v1 with: - node-version: 8.x + node-version: 10.x - name: Setup run: |