From 7e0600f39cea0594af0a885dfb4f18d3e1001a70 Mon Sep 17 00:00:00 2001 From: Jeff Posnick Date: Mon, 8 Nov 2021 09:33:29 -0500 Subject: [PATCH 1/2] Fix a TS type --- packages/workbox-strategies/src/index.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/workbox-strategies/src/index.ts b/packages/workbox-strategies/src/index.ts index ce0d4f4db..2ad7dbc91 100644 --- a/packages/workbox-strategies/src/index.ts +++ b/packages/workbox-strategies/src/index.ts @@ -18,7 +18,8 @@ import './_version.js'; // See https://github.com/GoogleChrome/workbox/issues/2946 declare global { interface FetchEvent { - readonly preloadResponse: Promise; + // See https://github.com/GoogleChrome/workbox/issues/2974 + readonly preloadResponse: Promise; } } From b0d79e25e040ea842db08a8977ee2096c0a71c13 Mon Sep 17 00:00:00 2001 From: Jeff Posnick Date: Mon, 8 Nov 2021 09:38:37 -0500 Subject: [PATCH 2/2] Linting --- packages/workbox-strategies/src/StrategyHandler.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/workbox-strategies/src/StrategyHandler.ts b/packages/workbox-strategies/src/StrategyHandler.ts index 6e555652b..cd110109d 100644 --- a/packages/workbox-strategies/src/StrategyHandler.ts +++ b/packages/workbox-strategies/src/StrategyHandler.ts @@ -155,7 +155,9 @@ class StrategyHandler { event instanceof FetchEvent && event.preloadResponse ) { - const possiblePreloadResponse = await event.preloadResponse; + const possiblePreloadResponse = (await event.preloadResponse) as + | Response + | undefined; if (possiblePreloadResponse) { if (process.env.NODE_ENV !== 'production') { logger.log(