Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s/QuickJS/QuickJS-NG/? #141

Closed
bnoordhuis opened this issue Nov 22, 2023 · 3 comments
Closed

s/QuickJS/QuickJS-NG/? #141

bnoordhuis opened this issue Nov 22, 2023 · 3 comments

Comments

@bnoordhuis
Copy link

As upstream quickjs development seems to be pretty dead, @saghul and yours truly begun a friendly fork over at https://github.com/quickjs-ng/quickjs that's been picking up momentum.

Do I summarize correctly that the requirements for adding/replacing are as follows?

  1. provide binaries at a stable location for:
  • i686 and x86_64 windows
  • i686 and x86_64 linux
  • arm64 macos
  1. provide at a stable location a LATEST.json with {"version":"x.y.z"} - or can jsvu compute that from GH release tags?

  2. PR jsvu with the new location?

@mathiasbynens
Copy link
Member

Your summary is spot-on! A LATEST.json (or .txt) would be ideal but most projects unfortunately don’t provide this. In those cases we can consult the GitHub API, like here: https://github.com/GoogleChromeLabs/jsvu/blob/main/engines/xs/get-latest-version.js

@bnoordhuis
Copy link
Author

Thanks for the quick reply, Mathias! I'll see if I can get GHA to produce a LATEST.json. Should I close this issue and PR when we're ready?

@mathiasbynens
Copy link
Member

Should I close this issue and PR when we're ready?

Sure, sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants