Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved the code #66

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tasospal
Copy link

@tasospal tasospal commented Feb 8, 2023

No description provided.

@google-cla
Copy link

google-cla bot commented Feb 8, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@tasospal tasospal changed the title first contribution improved the code Feb 8, 2023
@tasospal
Copy link
Author

tasospal commented Feb 14, 2023

Changes i made:

Index.html :
o width=device-width is updated to initial-scale=1, maximum-scale=1, user-scalable=no in the viewport meta tag.
o The script tag is updated to include the async attribute.
o The external link is updated to include target="_blank" and rel="noopener noreferrer" to prevent potential security
issues.
o The msapplication-navbutton-color meta tag is added to support Microsoft browsers.

Other.html :
o Added width=device-width to the viewport meta tag
o Removed initial-scale=1 from viewport meta tag since it is set by default
o Changed overflow property in body and html styles to default (omitted)
o Added error handling to Service Worker registration, displaying an error message if registration fails.
o Added a warning message if Service Worker is not supported in the browser

@tasospal tasospal closed this Jun 1, 2023
@tasospal tasospal reopened this Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants