Added support for a unique id when caching the site's manifest. #71
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
When used with a PWA which generates different content for each page (for example a profile page with a firstname, a lastname and an avatar and therefore different icons and splash screens) it happens that between several tabs open at the same time, the icons generated are identical at first (as long as you don't close the tabs - grants the documentation).
Indeed, the manifest file as well as the icons are stored with an identifier __pwacompat_manifest or __pwacompat_ios
To avoid this, I added support for a unique ID for each key.
If you need to display a PWA whose icons are dynamic, please enter a meta
pwacompat-manifest-id
tag with a unique identifier like uuid for exemple.Otherwise you will always have the same information between all tabs even if the content is different.
Thus the key in session will be personalized with the identifier.
Thanks☺️ ,
Sebastien