Skip to content
This repository has been archived by the owner on May 15, 2019. It is now read-only.

Handle missing logfiles correctly #199

Merged
merged 2 commits into from
Nov 16, 2018
Merged

Handle missing logfiles correctly #199

merged 2 commits into from
Nov 16, 2018

Conversation

ace-n
Copy link
Contributor

@ace-n ace-n commented Mar 29, 2018

As title - see relevant SO question.

(Also, there are some test failures - but I suspect they are unrelated to this PR.)

@ace-n ace-n requested a review from jmdobry March 29, 2018 00:39
@codecov
Copy link

codecov bot commented Mar 29, 2018

Codecov Report

Merging #199 into master will increase coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #199      +/-   ##
==========================================
+ Coverage   81.21%   81.25%   +0.04%     
==========================================
  Files          49       49              
  Lines        1954     1953       -1     
==========================================
  Hits         1587     1587              
+ Misses        367      366       -1
Impacted Files Coverage Δ
src/emulator/logs.js 33.33% <0%> (+0.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dbd883...50a7cb7. Read the comment docs.

@jmdobry jmdobry merged commit ca9200b into master Nov 16, 2018
@jmdobry jmdobry deleted the missing-logfiles branch November 16, 2018 18:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants