Skip to content
This repository has been archived by the owner on May 15, 2019. It is now read-only.

Update Node.js version warning message #261

Merged
merged 2 commits into from
Aug 1, 2018
Merged

Conversation

laurenzlong
Copy link
Contributor

@laurenzlong laurenzlong commented Jul 31, 2018

Fixes firebase/firebase-functions#292

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@laurenzlong
Copy link
Contributor Author

I've decided to not include the minor Node version in the message, since sometimes GCF auto-upgrades functions to a new Node version if the existing one has been found to have vulnerabilities.

@CodingDoug
Copy link

Could we add a link to the docs that discusses changing that targeted node runtime? The message currently states that node 6 and node 8 are supported, but the dev is given no guidance on how to make a choice, or which is the default.

https://firebase.google.com/docs/functions/manage-functions#set_nodejs_version

@laurenzlong
Copy link
Contributor Author

laurenzlong commented Jul 31, 2018

Since this warning message isn't just for Firebase, we would also need instructions for gcloud users. I actually wasn't able to find anything on how to configure runtime with gcloud, https://cloud.google.com/sdk/gcloud/reference/functions/deploy does not have any flags for runtime. Perhaps it is not yet updated. Jason, do you have any idea on where to find documentation on selecting runtime? And do you think it would be beneficial to to include links in this warning message?

@jmdobry
Copy link
Contributor

jmdobry commented Jul 31, 2018

@ace-n Do you know?

@laurenzlong
Copy link
Contributor Author

Thanks for approving! I don't have authorization to merge the pull request, can you do it if you're happy with it? And perhaps we can do a follow up PR to link to reference pages if one also exists for gcloud?

@jmdobry jmdobry merged commit 458f25d into master Aug 1, 2018
@jmdobry jmdobry deleted the laurenzlong-patch-2 branch August 1, 2018 03:26
@gligoran
Copy link
Contributor

gligoran commented Aug 9, 2018

@Shyam-Chen
Copy link

Need to modify the engine used. (#281)

@dungahk
Copy link

dungahk commented Nov 27, 2018

@gligoran I think that should have been updated, just like the README (https://github.com/GoogleCloudPlatform/cloud-functions-emulator/blob/master/README.md#note)

@grant
Copy link
Contributor

grant commented Apr 17, 2019

Note: This change has been published.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected Node.js v6.11.5 warning after functions update
7 participants