Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix go 1.11 CN issue #196

Merged

Conversation

kirbyquerby
Copy link
Contributor

Use a custom peer certificate check to verify our non-standard certificates.

fixes #194

…e is signed by the server CA since go 10.11 doesn't accept our non-standard CNs when verifying.

Thankfully, we retrieve the certificates from the Cloud SQL API and that connection is encrypted and verified, so customers are not risking a MITM attack with this.
@hfwang
Copy link
Contributor

hfwang commented Aug 5, 2018

Thanks!

@hfwang hfwang merged commit 9660231 into GoogleCloudPlatform:master Aug 5, 2018
@hfwang hfwang changed the title Fix go 10.11 CN issue Fix go 1.11 CN issue Aug 6, 2018
@forrestdix forrestdix mentioned this pull request Aug 29, 2018
@dim
Copy link

dim commented Sep 7, 2018

Are you planning to release this soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

x509 hostname errors on Go HEAD
3 participants