fix: allow evaluation of multi-turn conversations containing tool calls #1313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
github-actions
bot
added
the
owlbot:run
eliasecchig
reviewed
Oct 23, 2024
gemini/sample-apps/e2e-gen-ai-app-starter-pack/tests/integration/evaluation/test_evaluation.py
Outdated
Show resolved
Hide resolved
eliasecchig
reviewed
Oct 23, 2024
gemini/sample-apps/e2e-gen-ai-app-starter-pack/tests/integration/evaluation/test_evaluation.py
Outdated
Show resolved
Hide resolved
eliasecchig
reviewed
Oct 23, 2024
gemini/sample-apps/e2e-gen-ai-app-starter-pack/tests/integration/evaluation/test_evaluation.py
Outdated
Show resolved
Hide resolved
holtskinner
removed
the
owlbot:run
eliasecchig
force-pushed
the
evaluation
branch
from
67dd8e5 to
4c3f899
Compare
eliasecchig
force-pushed
the
evaluation
branch
from
1fa6cb7 to
2ff843b
Compare
holtskinner
approved these changes
Oct 25, 2024
inardini
pushed a commit
to inardini/generative-ai
that referenced
this pull request
Dec 7, 2024
…ls (GoogleCloudPlatform#1313) Main author: @mariagpuyol co-author: @eliasecchig We simplify the evaluation process on the starter pack. 1. Updated the poetry environment to use the new extra: google-cloud-aiplatform[evaluation] 2. Removed batch scoring utils functions to leverage the `batch` method with LangChain 3. Introduce support for tool calling processing within the ground truth --------- Co-authored-by: Elia Secchi <eliasecchi@google.com> Co-authored-by: Holt Skinner <holtskinner@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
CONTRIBUTINGGuide.CODEOWNERSfor the file(s).nox -s formatfrom the repository root to format).Main author: @mariagpuyol
co-author: @eliasecchig
We simplify the evaluation process on the starter pack.
batchmethod with LangChain