From 3a9e42e4e4074386389bf6a493dc3509211a80be Mon Sep 17 00:00:00 2001 From: Jennifer Davis Date: Mon, 26 Aug 2024 12:52:31 -0700 Subject: [PATCH] fix: modernize background app --- background/app/app.yaml | 2 +- background/app/main.py | 12 ++++-------- background/app/requirements.txt | 6 +++--- 3 files changed, 8 insertions(+), 12 deletions(-) diff --git a/background/app/app.yaml b/background/app/app.yaml index fb63451a..02c0651c 100644 --- a/background/app/app.yaml +++ b/background/app/app.yaml @@ -13,5 +13,5 @@ # limitations under the License. # [START getting_started_background_config] -runtime: python37 +runtime: python312 # [END getting_started_background_config] diff --git a/background/app/main.py b/background/app/main.py index 5474d54c..0bb1666d 100644 --- a/background/app/main.py +++ b/background/app/main.py @@ -64,12 +64,10 @@ def translate(): to_language = request.form.get("lang", "") if source_string == "": - error_message = "Empty value" - return error_message, 400 + return f"Invalid request, you must provide a value.", 400 if to_language not in ACCEPTABLE_LANGUAGES: - error_message = "Unsupported language: {}".format(to_language) - return error_message, 400 + return f"Unsupported language: {to_language}", 400 message = { "Original": source_string, @@ -78,11 +76,9 @@ def translate(): "OriginalLanguage": "", } - topic_name = "projects/{}/topics/{}".format( - os.getenv("GOOGLE_CLOUD_PROJECT"), "translate" - ) + topic_name = f"projects/{os.getenv('GOOGLE_CLOUD_PROJECT')}/topics/translate" publisher.publish( - topic=topic_name, data=json.dumps(message).encode("utf8") + topic=topic_name, data=json.dumps(message).encode("utf-8") ) return redirect("/") diff --git a/background/app/requirements.txt b/background/app/requirements.txt index 7cfba806..f70d16b7 100644 --- a/background/app/requirements.txt +++ b/background/app/requirements.txt @@ -1,3 +1,3 @@ -google-cloud-firestore==2.11.1 -google-cloud-pubsub==2.16.1 -flask==2.2.5 +google-cloud-firestore==2.18.0 +google-cloud-pubsub==2.23.0 +flask==3.0.3