From da24435fa3ed61137dab7ad655f542ed76fceac7 Mon Sep 17 00:00:00 2001 From: Gus Class Date: Mon, 15 May 2017 17:58:38 -0700 Subject: [PATCH 1/2] Adds test for encoded characters. --- .../google/cloud/language/samples/AnalyzeBetaIT.java | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/language/analysis/src/test/java/com/google/cloud/language/samples/AnalyzeBetaIT.java b/language/analysis/src/test/java/com/google/cloud/language/samples/AnalyzeBetaIT.java index 183ca7aeae0..97488e58e51 100644 --- a/language/analysis/src/test/java/com/google/cloud/language/samples/AnalyzeBetaIT.java +++ b/language/analysis/src/test/java/com/google/cloud/language/samples/AnalyzeBetaIT.java @@ -20,6 +20,7 @@ import com.google.cloud.language.spi.v1beta2.LanguageServiceClient; import com.google.cloud.language.v1beta2.Entity; +import com.google.cloud.language.v1beta2.EntityMention; import com.google.cloud.language.v1beta2.Sentiment; import org.junit.Before; @@ -28,6 +29,7 @@ import org.junit.runners.JUnit4; import java.util.List; +import java.util.Map; import java.util.stream.Collectors; /** @@ -66,6 +68,15 @@ public class AnalyzeBetaIT { assertThat(got).named("entity names").contains("Seattle"); } + @Test public void analyzeSyntax_entitySentimentTextEncoded() throws Exception { + List entities = analyzeApp.entitySentimentText("foo→bar"); + + List mentions = entities.listIterator().next().getMentionsList(); + + // Assert + assertThat(mentions.get(0).getText().getBeginOffset() == 4); + } + @Test public void analyzeSyntax_entitySentimentFile() throws Exception { List entities = analyzeApp.entitySentimentFile("gs://" + BUCKET + "/natural-language/gettysburg.txt"); From ef3b49e527d3a42740fc0c987634f4b6a2abc825 Mon Sep 17 00:00:00 2001 From: Gus Class Date: Tue, 16 May 2017 10:30:21 -0700 Subject: [PATCH 2/2] Fix style --- .../main/java/com/google/cloud/language/samples/Analyze.java | 2 +- .../java/com/google/cloud/language/samples/AnalyzeBetaIT.java | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/language/analysis/src/main/java/com/google/cloud/language/samples/Analyze.java b/language/analysis/src/main/java/com/google/cloud/language/samples/Analyze.java index e27f0ac37a1..49bb3d1e395 100644 --- a/language/analysis/src/main/java/com/google/cloud/language/samples/Analyze.java +++ b/language/analysis/src/main/java/com/google/cloud/language/samples/Analyze.java @@ -138,7 +138,7 @@ public static void printSyntax(PrintStream out, List tokens) { out.printf("\tBeginOffset: %d\n", token.getText().getBeginOffset()); out.printf("Lemma: %s\n", token.getLemma()); out.printf("PartOfSpeechTag: %s\n", token.getPartOfSpeech().getTag()); - out.printf("\tAspect: %s\n",token.getPartOfSpeech().getAspect()); + out.printf("\tAspect: %s\n", token.getPartOfSpeech().getAspect()); out.printf("\tCase: %s\n", token.getPartOfSpeech().getCase()); out.printf("\tForm: %s\n", token.getPartOfSpeech().getForm()); out.printf("\tGender: %s\n",token.getPartOfSpeech().getGender()); diff --git a/language/analysis/src/test/java/com/google/cloud/language/samples/AnalyzeBetaIT.java b/language/analysis/src/test/java/com/google/cloud/language/samples/AnalyzeBetaIT.java index 97488e58e51..dba254b469c 100644 --- a/language/analysis/src/test/java/com/google/cloud/language/samples/AnalyzeBetaIT.java +++ b/language/analysis/src/test/java/com/google/cloud/language/samples/AnalyzeBetaIT.java @@ -29,7 +29,6 @@ import org.junit.runners.JUnit4; import java.util.List; -import java.util.Map; import java.util.stream.Collectors; /**