Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-update dependencies. #1037

Merged
merged 9 commits into from
Mar 2, 2018
Merged

Auto-update dependencies. #1037

merged 9 commits into from
Mar 2, 2018

Conversation

dpebot
Copy link
Contributor

@dpebot dpebot commented Feb 22, 2018

Brought to you by your friendly Repository Gardener.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 22, 2018
@lesv
Copy link
Contributor

lesv commented Feb 22, 2018

@tswast PTAL

------------------------------------------------------------
- testing appengine-java8/bigquery
------------------------------------------------------------
[ERROR] COMPILATION ERROR : 
[ERROR] /tmpfs/src/github/java-docs-samples/appengine-java8/bigquery/src/main/java/com/example/appengine/bigquerylogging/BigQueryRunner.java:[33,60] package com.google.cloud.monitoring.v3.PagedResponseWrappers does not exist
[ERROR] /tmpfs/src/github/java-docs-samples/appengine-java8/bigquery/src/main/java/com/example/appengine/bigquerylogging/BigQueryRunner.java:[34,60] package com.google.cloud.monitoring.v3.PagedResponseWrappers does not exist
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.6.2:compile (default-compile) on project appengine-bigquery-monitoring-j8: Compilation failure: Compilation failure: 
[ERROR] /tmpfs/src/github/java-docs-samples/appengine-java8/bigquery/src/main/java/com/example/appengine/bigquerylogging/BigQueryRunner.java:[33,60] package com.google.cloud.monitoring.v3.PagedResponseWrappers does not exist
[ERROR] /tmpfs/src/github/java-docs-samples/appengine-java8/bigquery/src/main/java/com/example/appengine/bigquerylogging/BigQueryRunner.java:[34,60] package com.google.cloud.monitoring.v3.PagedResponseWrappers does not exist

Copy link
Contributor

@lesv lesv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tswast PTAL

@tswast
Copy link
Contributor

tswast commented Feb 22, 2018

Uh, that's weird. I think I saw a thread on the veneer Java team about this. Something about GAX needing to be updated across all packages. Maybe there's a mis-match with the latest BigQuery lib?

@tswast
Copy link
Contributor

tswast commented Feb 22, 2018

Garrett confirmed there was a breaking change in the monitoring API. Why the appengine-java8/bigquery sample uses the monitoring API, I don't know.

@dzlier-gcp can you update the monitoring part of this sample?

@dzlier-gcp
Copy link
Member

It's not just a bigquery sample, it's part of the API Showcase I did for the java documentation page that combines two highly used products into one sample.

Does the usage just need to be updated, or does it need to be removed entirely until the API is fixed?

@dpebot dpebot force-pushed the dpebot-repositorygardener branch from 3c399c8 to 37f2b12 Compare February 23, 2018 17:50
@tswast
Copy link
Contributor

tswast commented Feb 23, 2018 via email

@lesv
Copy link
Contributor

lesv commented Feb 23, 2018

Don't do exceptions for google-cloud-java -- that would defeat our basic purpose.

@dzlier-gcp
Copy link
Member

Done

@dpebot dpebot force-pushed the dpebot-repositorygardener branch 2 times, most recently from 09f6ff8 to 3c36aa6 Compare February 25, 2018 17:50
@lesv
Copy link
Contributor

lesv commented Feb 25, 2018

@dzlier-gcp Doesn't appear to have been fixed.

@lesv lesv added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 25, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 25, 2018
@dpebot dpebot force-pushed the dpebot-repositorygardener branch from 3c36aa6 to 775f741 Compare February 26, 2018 17:50
@lesv
Copy link
Contributor

lesv commented Feb 26, 2018

******************** TESTING AFFECTED PROJECTS ********************
------------------------------------------------------------
- testing appengine-java8/bigquery
------------------------------------------------------------
[ERROR] COMPILATION ERROR : 
[ERROR] /tmpfs/src/github/java-docs-samples/appengine-java8/bigquery/src/main/java/com/example/appengine/bigquerylogging/BigQueryRunner.java:[33,60] package com.google.cloud.monitoring.v3.PagedResponseWrappers does not exist
[ERROR] /tmpfs/src/github/java-docs-samples/appengine-java8/bigquery/src/main/java/com/example/appengine/bigquerylogging/BigQueryRunner.java:[34,60] package com.google.cloud.monitoring.v3.PagedResponseWrappers does not exist
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.6.2:compile (default-compile) on project appengine-bigquery-monitoring-j8: Compilation failure: Compilation failure: 
[ERROR] /tmpfs/src/github/java-docs-samples/appengine-java8/bigquery/src/main/java/com/example/appengine/bigquerylogging/BigQueryRunner.java:[33,60] package com.google.cloud.monitoring.v3.PagedResponseWrappers does not exist
[ERROR] /tmpfs/src/github/java-docs-samples/appengine-java8/bigquery/src/main/java/com/example/appengine/bigquerylogging/BigQueryRunner.java:[34,60] package com.google.cloud.monitoring.v3.PagedResponseWrappers does not exist

@tswast
Copy link
Contributor

tswast commented Feb 26, 2018

I imagine @dzlier-gcp's commits disappeared because dpebot updates its branch nightly. Best to make Java code changes outside this branch if they aren't going to get merged that day.

@lesv
Copy link
Contributor

lesv commented Feb 26, 2018

I didn't see his commit in the archive, perhaps they weren't pushed. Anyway @dzlier-gcp once you get kokoro to pass, feel free to merge immediately.

@dpebot dpebot force-pushed the dpebot-repositorygardener branch 2 times, most recently from 4305835 to c5a6053 Compare March 1, 2018 17:50
@kurtisvg kurtisvg force-pushed the dpebot-repositorygardener branch 3 times, most recently from b795ea7 to c0d769a Compare March 1, 2018 22:10
@dpebot dpebot force-pushed the dpebot-repositorygardener branch from e7102bc to a5ee275 Compare March 2, 2018 17:50
@lesv lesv merged commit 8f1fe1d into master Mar 2, 2018
@lesv lesv deleted the dpebot-repositorygardener branch March 2, 2018 19:27
@lesv
Copy link
Contributor

lesv commented Mar 2, 2018

Thank you @kurtisvg

Shabirmean pushed a commit that referenced this pull request Nov 14, 2022
…1.3 (#1037)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:libraries-bom](https://cloud.google.com/java/docs/bom) ([source](https://togithub.com/googleapis/java-cloud-bom)) | `26.1.2` -> `26.1.3` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.3/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.3/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.3/compatibility-slim/26.1.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.3/confidence-slim/26.1.2)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-dialogflow).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMTkuMSIsInVwZGF0ZWRJblZlciI6IjMyLjIxOS4xIn0=-->
Shabirmean pushed a commit that referenced this pull request Nov 15, 2022
…1.3 (#1037)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:libraries-bom](https://cloud.google.com/java/docs/bom) ([source](https://togithub.com/googleapis/java-cloud-bom)) | `26.1.2` -> `26.1.3` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.3/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.3/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.3/compatibility-slim/26.1.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.3/confidence-slim/26.1.2)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-dialogflow).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMTkuMSIsInVwZGF0ZWRJblZlciI6IjMyLjIxOS4xIn0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants