Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes http test to point to better hosting #663

Merged
merged 6 commits into from
May 15, 2017
Merged

Changes http test to point to better hosting #663

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
40e8bac
Changes http test to point to better hosting.
gguuss May 12, 2017
aeb6891
Use Cloud Storage bucket for web URI test
gguuss May 12, 2017
b0a6f51
Style nit
gguuss May 12, 2017
05ef898
Merge branch 'master' into vision-http-flaky
lesv May 15, 2017
1c37152
Change test to public GCS bucket.
gguuss May 15, 2017
d62d74e
Change test to environment variable.
gguuss May 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion vision/cloud-client/src/test/java/com/example/vision/DetectIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ public void testLandmarksGcs() throws Exception {
@Test
public void testLandmarksUrl() throws Exception {
// Act
String[] args = {"landmarks", "https://pbs.twimg.com/media/C4wfMOhVcAAUAgq.jpg"};
String[] args = {"landmarks", "http://wheresgus.com/landmark.jpg"};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should put this image in GCS associated to this project?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, I had tried our existing repos but I'm not sure if any are public. If we don't have a public bucket, maybe it's time for one?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we have a public bucket. In Ruby, vision sample tests upload the image before testing a sample.

I do agree, It may be a good idea to have a public bucket we can all use in our samples.

Copy link
Contributor Author

@gguuss gguuss May 15, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cloud-samples-tests is working for me, I'm not sure whether the environment for CI is using that bucket.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the project that this repo uses in circle is java-docs-samples-tests.

Are you referring the errors found at https://circleci.com/gh/GoogleCloudPlatform/java-docs-samples/388?

Running com.example.vision.DetectIT
May 12, 2017 11:22:35 PM io.netty.util.internal.MacAddressUtil defaultMachineId
WARNING: Failed to find a usable hardware address from the network interfaces; using random bytes: 59:89:0f:b8:80:fa:c5:65
Tests run: 21, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 35.985 sec <<< FAILURE! - in com.example.vision.DetectIT
testLandmarksUrl(com.example.vision.DetectIT)  Time elapsed: 2.071 sec  <<< FAILURE!
java.lang.AssertionError: 
Not true that <"Error: image-annotator::Malformed request.: The URL does not appear to be accessible by us. Please double check or download the image and pass it in.
"> contains <"Palace of Fine Arts">
	at com.example.vision.DetectIT.testLandmarksUrl(DetectIT.java:134)
Caused by: java.lang.AssertionError: 
Not true that <"Error: image-annotator::Malformed request.: The URL does not appear to be accessible by us. Please double check or download the image and pass it in.
"> contains <"Palace of Fine Arts">
	at com.example.vision.DetectIT.testLandmarksUrl(DetectIT.java:134)

Detect.argsHelper(args, out);

// Assert
Expand Down