Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates instructions for jar installation #869

Merged
merged 3 commits into from
Sep 28, 2017
Merged

Updates instructions for jar installation #869

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
455971d
Updates instructions for jar installation
gguuss Sep 26, 2017
16b5fe4
Merge branch 'master' into iot-snippets
lesv Sep 27, 2017
5f45508
Merge branch 'master' into iot-snippets
gguuss Sep 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion iot/api-client/manager/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ PubSub topic for Cloud IoT as described in [the parent README](../README.md).
Manually install [the provided client library](https://cloud.google.com/iot/resources/java/cloud-iot-core-library.jar)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are really going to do this, shouldn't you put it in a GCS bucket? Also, you might wish to include the pom.xml as it has the dependencies in it.

Copy link
Contributor Author

@gguuss gguuss Sep 26, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intent is to fallback to the existing way we're distributing the bits so we don't end up having the sample broken if something goes wrong in deploying to Maven.

The library is on devsite where (behind a whitelist) but today I realized the instructions are currently broken as the groupID didn't match what's in POM.xml.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle is still failing - would be good to fix it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it's the Storage-JSON API failing, so I'm ok w/ this once you figure out the library in a way that can be tested.

for Cloud IoT Core to Maven:

mvn install:install-file -Dfile=cloud-iot-core-library.jar -DgroupId=com.example.apis \
mvn install:install-file -Dfile=cloud-iot-core-library.jar -DgroupId=com.google.apis \
-DartifactId=google-api-services-cloudiot -Dversion=v1beta1-rev20170926-1.22.0-SNAPSHOT \
-Dpackaging=jar

Expand Down