-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade peer/dev deps to @opentelemetry 0.14.0 #208
chore: upgrade peer/dev deps to @opentelemetry 0.14.0 #208
Conversation
Codecov Report
@@ Coverage Diff @@
## master #208 +/- ##
==========================================
+ Coverage 95.30% 95.36% +0.05%
==========================================
Files 11 11
Lines 341 345 +4
Branches 67 67
==========================================
+ Hits 325 329 +4
Misses 16 16
Continue to review full report at Codecov.
|
a9f4801
to
0846bd4
Compare
not sure if anyone's aware of it, but using the current stable version (0.7.0) with opentelemetry 0.13.0 causes a torrent of errors like this:
|
@electricmonk yes, this PR is the fix. The opentelemetry-operations-js/packages/opentelemetry-cloud-trace-exporter/package.json Lines 65 to 68 in facb8e0
|
ETA for release? current latest is not working (as you are all aware) |
@aabmass note that open telemetry 0.14 was recently released. |
Thanks for review @mayurkale22 🙂 |
Fixes #215
Upgrading peer/dev deps and fixing the associated breaking changes from upstream. Mainly:
ExportResult
was changed into an object with separatecode
anderror
fieldsExportResult
enum is nowExportResultCode
andFAILED_RETRYABLE
was removed.Meter.getBatcher()
->Meter.getProcessor()
CanonicalCode
->StatusCode
fields()
method (see spec).Tested the new packages manually as well, everything is working great.