Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade peer/dev deps to @opentelemetry 0.14.0 #208

Merged
merged 5 commits into from
Dec 28, 2020

Conversation

aabmass
Copy link
Contributor

@aabmass aabmass commented Dec 9, 2020

Fixes #215

Upgrading peer/dev deps and fixing the associated breaking changes from upstream. Mainly:

  • Propagator getters and setters were changed into classes and renamed
  • ExportResult was changed into an object with separate code and error fields
  • ExportResult enum is now ExportResultCode and FAILED_RETRYABLE was removed.
  • Meter.getBatcher() -> Meter.getProcessor()
  • CanonicalCode -> StatusCode
  • Propagators have a new fields() method (see spec).

Tested the new packages manually as well, everything is working great.

@codecov
Copy link

codecov bot commented Dec 9, 2020

Codecov Report

Merging #208 (7043a27) into master (767b464) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #208      +/-   ##
==========================================
+ Coverage   95.30%   95.36%   +0.05%     
==========================================
  Files          11       11              
  Lines         341      345       +4     
  Branches       67       67              
==========================================
+ Hits          325      329       +4     
  Misses         16       16              
Impacted Files Coverage Δ
...emetry-cloud-monitoring-exporter/src/monitoring.ts 89.41% <100.00%> (+0.12%) ⬆️
...es/opentelemetry-cloud-trace-exporter/src/trace.ts 96.29% <100.00%> (ø)
...etry-cloud-trace-propagator/src/CloudPropagator.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 767b464...7043a27. Read the comment docs.

@aabmass aabmass force-pushed the upgrade-otel-0.13.0 branch from a9f4801 to 0846bd4 Compare December 9, 2020 18:33
@aabmass aabmass marked this pull request as ready for review December 9, 2020 18:35
@aabmass aabmass requested review from a team and mayurkale22 December 9, 2020 18:35
@electricmonk
Copy link

not sure if anyone's aware of it, but using the current stable version (0.7.0) with opentelemetry 0.13.0 causes a torrent of errors like this:

TypeError: Cannot read property 'FAILED_RETRYABLE' of undefined
at TraceExporter._batchWriteSpans (/app/node_modules/@google-cloud/opentelemetry-cloud-trace-exporter/build/src/trace.js:91:40)
at runMicrotasks (<anonymous>)
at processTicksAndRejections (internal/process/task_queues.js:97:5)
at async TraceExporter.export (/app/node_modules/@google-cloud/opentelemetry-cloud-trace-exporter/build/src/trace.js:61:24)

@aabmass
Copy link
Contributor Author

aabmass commented Dec 14, 2020

@electricmonk yes, this PR is the fix. The peerDependencies in each package are correct and things should be working as long as they are satisfied:

"@opentelemetry/api": "^0.12.0",
"@opentelemetry/core": "^0.12.0",
"@opentelemetry/resources": "^0.12.0",
"@opentelemetry/tracing": "^0.12.0"

@erlichmen
Copy link

ETA for release? current latest is not working (as you are all aware)

@sk-
Copy link

sk- commented Dec 24, 2020

@aabmass note that open telemetry 0.14 was recently released.

@aabmass aabmass changed the title chore: upgrade peer/dev deps to @opentelemetry 0.13.0 chore: upgrade peer/dev deps to @opentelemetry 0.14.0 Dec 28, 2020
@aabmass
Copy link
Contributor Author

aabmass commented Dec 28, 2020

Thanks for review @mayurkale22 🙂

@aabmass aabmass merged commit b91df9b into GoogleCloudPlatform:master Dec 28, 2020
@aabmass aabmass deleted the upgrade-otel-0.13.0 branch December 28, 2020 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot read property 'FAILED_RETRYABLE' of undefined
5 participants