Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: drop support for node 10 and 12 #477

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

aabmass
Copy link
Contributor

@aabmass aabmass commented Dec 19, 2022

Fixes #476

Question for the group, should we consider this a breaking change and do major version bumps on stable packages?

@codecov
Copy link

codecov bot commented Dec 19, 2022

Codecov Report

Merging #477 (61d1dc9) into main (70da73b) will not change coverage.
The diff coverage is n/a.

❗ Current head 61d1dc9 differs from pull request most recent head 9c93b1e. Consider uploading reports for the commit 9c93b1e to get more accurate results

@@           Coverage Diff           @@
##             main     #477   +/-   ##
=======================================
  Coverage   95.64%   95.64%           
=======================================
  Files          16       16           
  Lines         551      551           
  Branches      103      103           
=======================================
  Hits          527      527           
  Misses         24       24           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aabmass aabmass marked this pull request as ready for review December 20, 2022 04:25
@aabmass aabmass requested a review from a team December 20, 2022 04:25
@aabmass aabmass force-pushed the update-node-versions-476 branch from 2d20c1b to 9c93b1e Compare December 20, 2022 04:33
@dashpole
Copy link
Contributor

I think the answer is yes. There are a bunch of open issues in the semvar repo about it with people being confused (are node engine versions a "dependency", or an API contract?), but the overall gist seems to be that a change which might requires user action is breaking.

@aabmass
Copy link
Contributor Author

aabmass commented Dec 20, 2022

That makes sense. Do we plan to bump the Go API/SDK and our exporters each time we increase the version though?

The Python SIG does not bump the API/SDK when we dropped older python versions fwiw

@dashpole
Copy link
Contributor

That makes sense. Do we plan to bump the Go API/SDK and our exporters each time we increase the version though?

Yes, but only for major version bumps of Go. Is this change considered a major version bump of nodejs, or a minor version bump? I had assumed it was a major bump.

@aabmass
Copy link
Contributor Author

aabmass commented Jan 5, 2023

I guess it is major but new major versions of Node come out frequently, every ~6 month. Here is the lifecycle of current node versions for reference https://nodejs.dev/en/about/releases/
image

I dug into upstream OTel and it looks like they made a similar change in open-telemetry/opentelemetry-js#3048 and did not bump any major versions.

@aabmass
Copy link
Contributor Author

aabmass commented Jan 5, 2023

This seems to be a frequent hot topic for semver semver/semver#716 with no answer. I took a look at some other Google API PRs and found they consider it a breaking change, e.g. googleapis/nodejs-storage#1876.

Let's go with that @dashpole. I've already marked this PR with ! in the title so should be good to go :)

@aabmass aabmass enabled auto-merge (squash) January 5, 2023 23:13
@aabmass aabmass disabled auto-merge January 6, 2023 01:08
@aabmass aabmass merged commit 7f393f8 into GoogleCloudPlatform:main Jan 6, 2023
@aabmass aabmass deleted the update-node-versions-476 branch January 6, 2023 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update supported node versions
2 participants