-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: drop support for node 10 and 12 #477
chore!: drop support for node 10 and 12 #477
Conversation
Codecov Report
@@ Coverage Diff @@
## main #477 +/- ##
=======================================
Coverage 95.64% 95.64%
=======================================
Files 16 16
Lines 551 551
Branches 103 103
=======================================
Hits 527 527
Misses 24 24 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
2d20c1b
to
9c93b1e
Compare
I think the answer is yes. There are a bunch of open issues in the semvar repo about it with people being confused (are node engine versions a "dependency", or an API contract?), but the overall gist seems to be that a change which might requires user action is breaking. |
That makes sense. Do we plan to bump the Go API/SDK and our exporters each time we increase the version though? The Python SIG does not bump the API/SDK when we dropped older python versions fwiw |
Yes, but only for major version bumps of Go. Is this change considered a major version bump of nodejs, or a minor version bump? I had assumed it was a major bump. |
I guess it is major but new major versions of Node come out frequently, every ~6 month. Here is the lifecycle of current node versions for reference https://nodejs.dev/en/about/releases/ I dug into upstream OTel and it looks like they made a similar change in open-telemetry/opentelemetry-js#3048 and did not bump any major versions. |
This seems to be a frequent hot topic for semver semver/semver#716 with no answer. I took a look at some other Google API PRs and found they consider it a breaking change, e.g. googleapis/nodejs-storage#1876. Let's go with that @dashpole. I've already marked this PR with |
Fixes #476
Question for the group, should we consider this a breaking change and do major version bumps on stable packages?