feat(autoconfig): autoconfig module #1308
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
has shared properties to be used by generated spring autoconfigured client beans
zhumin8
requested changes
Oct 26, 2022
...red-autoconfig-properties/src/main/java/com/google/cloud/spring/shared/SharedProperties.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Min Zhu <zhumin@google.com>
elefeint
suggested changes
Nov 14, 2022
...red-autoconfig-properties/src/main/java/com/google/cloud/spring/shared/SharedProperties.java
Outdated
Show resolved
Hide resolved
diegomarquezp
commented
Nov 21, 2022
blakeli0
reviewed
Nov 22, 2022
emmileaf
suggested changes
Nov 23, 2022
...bal-autoconfig-properties/src/main/java/com/google/cloud/spring/global/GlobalProperties.java
Show resolved
Hide resolved
emmileaf
reviewed
Nov 24, 2022
...bal-autoconfig-properties/src/main/java/com/google/cloud/spring/global/GlobalProperties.java
Outdated
Show resolved
Hide resolved
…e/cloud/spring/global/GlobalProperties.java Co-authored-by: Emily Wang <emmwang@google.com>
emmileaf
reviewed
Nov 24, 2022
emmileaf
approved these changes
Nov 25, 2022
zhumin8
reviewed
Nov 29, 2022
...bal-autoconfig-properties/src/main/java/com/google/cloud/spring/global/GlobalProperties.java
Show resolved
Hide resolved
5 tasks
|
Perhaps get some test coverage with a simple test with fake credential key? |
|
Kudos, SonarCloud Quality Gate passed! |
meltsufin
reviewed
Dec 2, 2022
elefeint
approved these changes
Dec 2, 2022
|
Closing as not planned |
zhumin8
added a commit
to googleapis/sdk-platform-java
that referenced
this pull request
Dec 16, 2022
…1123) As discussed off-line, instead of depending on a new `global-properties` module, use `CredentialsProvider` bean from `spring-cloud-gcp-autoconfigure` instead. - Replace dependency from `core` to `autoconfigure` module. - Revert #1071 and implement changes shown in [poc](zhumin8/language_poc1#7) - Minor code cleanups and util method extracted from `SpringPropertiesClassComposer.java`. Note: #1071 and GoogleCloudPlatform/spring-cloud-gcp#1308 will be obsolete after this change. Also, conflicts needs to be resolved between this pr and #1110 depending on merging order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
has shared properties to be used by generated spring autoconfigured client beans