Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump min gradle version to 5.1 and fix deprecation warnings #2219

Merged
merged 3 commits into from
Jan 7, 2020
Merged

Bump min gradle version to 5.1 and fix deprecation warnings #2219

merged 3 commits into from
Jan 7, 2020

Conversation

TadCordle
Copy link
Contributor

Fixes #2166.

@TadCordle TadCordle requested a review from a team January 7, 2020 20:10
@TadCordle
Copy link
Contributor Author

Hang on, integration test failing...

@TadCordle TadCordle removed the request for review from a team January 7, 2020 20:12
@chanseokoh
Copy link
Member

chanseokoh commented Jan 7, 2020 •
edited
Loading

You should update https://github.com/GoogleContainerTools/jib/pull/2210/files#diff-aef8bf567c91df6622aa0ea29ed0c682R45 (assuming the API are available in 5.1). Actually, all of the #2210 changes.

@TadCordle TadCordle changed the title Fix deprecation warnings for gradle 5+ Bump min gradle version to 5.1 and fix deprecation warnings Jan 7, 2020
@TadCordle TadCordle requested a review from a team January 7, 2020 21:02
@chanseokoh
Copy link
Member

chanseokoh commented Jan 7, 2020 •
edited
Loading

Does the full integration test pass? Running actual Jib builds is the only way to know if the API is available in 5.1.

@TadCordle
Copy link
Contributor Author

It failed on 5.0 but it doesn't anymore.

@TadCordle TadCordle merged commit 8709837 into master Jan 7, 2020
@TadCordle TadCordle deleted the i2166-fix-deprecation branch January 7, 2020 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chanseokoh chanseokoh chanseokoh approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecation warning on AbstractArchiveTask methods
3 participants
@TadCordle @chanseokoh @googlebot