Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ga-beacon to README. #509

Merged
merged 17 commits into from
Jul 10, 2018
Merged

Adds ga-beacon to README. #509

merged 17 commits into from
Jul 10, 2018

Conversation

coollog
Copy link
Contributor

@coollog coollog commented Jul 6, 2018

@coollog coollog requested a review from a team July 6, 2018 14:54
@chanseokoh
Copy link
Member

The instructions say

The ga-beacon.appspot.com instance is a demo instance, good for prototyping and proof of concepts. If you intend to use this in production for your application, you should deploy your own instance of this service,

@coollog
Copy link
Contributor Author

coollog commented Jul 9, 2018

I think we can add this for now to try it out (as a proof of concept/prototype), and then deploy our own instance(s) if it works well for us.

@coollog
Copy link
Contributor Author

coollog commented Jul 10, 2018

Will be deploying our own App Engine instance.

@coollog
Copy link
Contributor Author

coollog commented Jul 10, 2018

Filed #535 for moving beacon fork to team org.

The beacon is deployed and the PR is updated.

@coollog
Copy link
Contributor Author

coollog commented Jul 10, 2018

Made the beacon a pixel since the badge doesn't provide much value to viewers.

@coollog coollog merged commit 9ac0362 into master Jul 10, 2018
@coollog coollog deleted the coollog-patch-2 branch July 10, 2018 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants