Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed Block: AMP Compatibility Workaround #3258

Closed
swissspidy opened this issue Jul 17, 2020 · 1 comment · Fixed by #3261
Closed

Embed Block: AMP Compatibility Workaround #3258

swissspidy opened this issue Jul 17, 2020 · 1 comment · Fixed by #3261
Labels
AMP Format Issues that need to be addressed in the AMP story format AMP Output Issues related to AMP output and validation Group: WordPress Changes related to WordPress or Gutenberg integration Status: Not Implemented Issue/PR we will (likely) not implement Type: Enhancement New feature or improvement of an existing feature

Comments

@swissspidy
Copy link
Collaborator

Feature Description

The <amp-story-player> component is not yet AMP compatible, which is why for example the AMP plugin is removing it from the page when using Standard mode.

To work around this for the time being, the idea is to use <amp-iframe> instead.

Basically, instead of using <amp-story-player> directly we would use <amp-iframe> to embed a document that contains nothing but the player.

The crux is creating such a document in a secure way, i.e. it should probably only allow loading the player with the block's actual attributes, and not just any arbitrary data.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance Criteria

Implementation Brief

@swissspidy swissspidy added Type: Enhancement New feature or improvement of an existing feature Group: WordPress Changes related to WordPress or Gutenberg integration AMP Output Issues related to AMP output and validation Pod: WP & Infra labels Jul 17, 2020
@swissspidy swissspidy self-assigned this Jul 17, 2020
@swissspidy swissspidy added the AMP Format Issues that need to be addressed in the AMP story format label Jul 21, 2020
@swissspidy
Copy link
Collaborator Author

Looks like this will have mostly resolved itself now that the player works in AMP. We just need to wait for the AMP plugin 2.0 release, see ampproject/amp-wp#5075

@swissspidy swissspidy removed their assignment Jul 21, 2020
@swissspidy swissspidy added Status: Not Applicable Issue that cannot be confirmed or is not an actual issue. Status: Not Implemented Issue/PR we will (likely) not implement and removed Status: Not Applicable Issue that cannot be confirmed or is not an actual issue. labels Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AMP Format Issues that need to be addressed in the AMP story format AMP Output Issues related to AMP output and validation Group: WordPress Changes related to WordPress or Gutenberg integration Status: Not Implemented Issue/PR we will (likely) not implement Type: Enhancement New feature or improvement of an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant