-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add an option to immediately remote verify #228
base: main
Are you sure you want to change the base?
Conversation
cc: @flawedworld |
Ah, I see the ID 0 used for the periodic jobs. Shall we use the ID 1 for "fire-once" job then? (I see that 1 is used for Edited: |
There's a first run job to get the initial pairing done with extremely high priority so users don't need to wait for it to appear even if they're in battery saver mode, etc. |
@@ -548,7 +549,19 @@ public boolean onOptionsItemSelected(final MenuItem item) { | |||
stage = Stage.EnableRemoteVerify; | |||
startQrScanner(); | |||
return true; | |||
} else if (itemId == R.id.action_disable_remote_verify) { | |||
} | |||
else if (itemId == R.id.action_remote_verify_now) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be right to use PERMISSIONS_REQUEST_POST_NOTIFICATIONS_REMOTE_VERIFY
?
0b1e725
to
1143970
Compare
42aa1c8
to
3adc5f9
Compare
ac2dde3
to
6a0e6c2
Compare
72363db
to
34e6d8d
Compare
3581800
to
a5f4f7b
Compare
444f5d4
to
39a89da
Compare
This PR adds an option in the menu bar that says "Remote verify now". It will schedule an immediate job that performs the Remote Verification Job instead of the regular periodic trigger.
Fixes #197